components/signin/core/browser/account_info_unittest.cc - Issue 1588913002: Fix AccountInfo uninitialized memory issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/account_info_unittest.cc

Issue 1588913002: Fix AccountInfo uninitialized memory issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Explicit default value to false Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/signin/core/browser/account_info_unittest.cc

diff --git a/components/signin/core/browser/account_info_unittest.cc b/components/signin/core/browser/account_info_unittest.cc

index 2d9928d798f35856c5d263a55bc96da8a64e449f..663ad4efecf56016229fca045576bb6add72cce2 100644

--- a/components/signin/core/browser/account_info_unittest.cc

+++ b/components/signin/core/browser/account_info_unittest.cc

@@ -57,13 +57,7 @@ TEST_F(AccountInfoTest, UpdateWithNoModification) {

}

// Tests that UpdateWith() correctly updates its fields that were not set.

-// Fails under MSan. crbug.com/577333

-#if defined(MEMORY_SANITIZER)

-#define MAYBE_UpdateWithSuccessfulUpdate DISABLED_UpdateWithSuccessfulUpdate

-#else

-#define MAYBE_UpdateWithSuccessfulUpdate UpdateWithSuccessfulUpdate

-#endif

-TEST_F(AccountInfoTest, MAYBE_UpdateWithSuccessfulUpdate) {

+TEST_F(AccountInfoTest, UpdateWithSuccessfulUpdate) {

AccountInfo info;

info.account_id = info.gaia = info.email = "test_id";