Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1588883005: Make sure the event blocker is destroyed when we leave maximize mode. (Closed)

Created:
4 years, 11 months ago by afakhry
Modified:
4 years, 11 months ago
Reviewers:
varkha
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure the event blocker is destroyed when we leave maximize mode. Turning off the internal display while an external one is connected will enter the device into docked mode, and will exit the maximized mode (if any). We need to make sure that the keyboard and touchpad events are re-enabled when the maximize mode exits. BUG=549803 TEST=ash_unittests --gtest_filter=MaximizeModeControllerTest.NoMaximizeModeWithDisabledInternalDisplay Committed: https://crrev.com/bf0b91e43cd331c6ebdb80755a2a74bd71f259ab Cr-Commit-Position: refs/heads/master@{#370436}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -17 lines) Patch
M ash/wm/maximize_mode/maximize_mode_controller.cc View 1 chunk +27 lines, -17 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
afakhry
flackr@chromium.org: Could you please review? Thanks!
4 years, 11 months ago (2016-01-15 02:16:18 UTC) #2
afakhry
flackr is OOO. varkha, could you please review?
4 years, 11 months ago (2016-01-15 18:51:56 UTC) #4
varkha
lgtm
4 years, 11 months ago (2016-01-16 04:36:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588883005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588883005/1
4 years, 11 months ago (2016-01-20 18:03:17 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 18:44:27 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 18:45:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf0b91e43cd331c6ebdb80755a2a74bd71f259ab
Cr-Commit-Position: refs/heads/master@{#370436}

Powered by Google App Engine
This is Rietveld 408576698