Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: ash/wm/maximize_mode/maximize_mode_controller.cc

Issue 1588883005: Make sure the event blocker is destroyed when we leave maximize mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/wm/maximize_mode/maximize_mode_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/maximize_mode/maximize_mode_controller.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_controller.cc b/ash/wm/maximize_mode/maximize_mode_controller.cc
index 146a3786b0d44d93a945d6a9ba14332a9adb0a20..f75ead3297b41ac5e9207705a0422dc5f65d3ced 100644
--- a/ash/wm/maximize_mode/maximize_mode_controller.cc
+++ b/ash/wm/maximize_mode/maximize_mode_controller.cc
@@ -290,38 +290,48 @@ void MaximizeModeController::HandleHingeRotation(
if (lid_open_past_180_ && is_angle_stable &&
lid_angle <= kExitMaximizeModeAngle) {
lid_open_past_180_ = false;
- if (!base::CommandLine::ForCurrentProcess()->
- HasSwitch(switches::kAshEnableTouchViewTesting)) {
- LeaveMaximizeMode();
- }
- event_blocker_.reset();
+ LeaveMaximizeMode();
} else if (!lid_open_past_180_ && !lid_is_closed_ &&
lid_angle >= kEnterMaximizeModeAngle &&
(is_angle_stable || !WasLidOpenedRecently())) {
lid_open_past_180_ = true;
- if (!base::CommandLine::ForCurrentProcess()->
- HasSwitch(switches::kAshEnableTouchViewTesting)) {
- EnterMaximizeMode();
- }
- // Always reset first to avoid creation before destruction of a previous
- // object.
- event_blocker_.reset();
-#if defined(USE_X11)
- event_blocker_.reset(new ScopedDisableInternalMouseAndKeyboardX11);
-#elif defined(USE_OZONE)
- event_blocker_.reset(new ScopedDisableInternalMouseAndKeyboardOzone);
-#endif
+ EnterMaximizeMode();
}
}
#endif // OS_CHROMEOS
void MaximizeModeController::EnterMaximizeMode() {
+ // Always reset first to avoid creation before destruction of a previous
+ // object.
+ event_blocker_.reset();
+#if defined(USE_X11)
+ event_blocker_.reset(new ScopedDisableInternalMouseAndKeyboardX11);
+#elif defined(USE_OZONE)
+ event_blocker_.reset(new ScopedDisableInternalMouseAndKeyboardOzone);
+#endif
+
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kAshEnableTouchViewTesting)) {
+ // We don't let accelerometer updates interfere with the maximize mode
+ // status as set by the touch-view-testing keyboard shortcut.
+ return;
+ }
+
if (IsMaximizeModeWindowManagerEnabled())
return;
EnableMaximizeModeWindowManager(true);
}
void MaximizeModeController::LeaveMaximizeMode() {
+ event_blocker_.reset();
+
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kAshEnableTouchViewTesting)) {
+ // We don't let accelerometer updates interfere with the maximize mode
+ // status as set by the touch-view-testing keyboard shortcut.
+ return;
+ }
+
if (!IsMaximizeModeWindowManagerEnabled())
return;
EnableMaximizeModeWindowManager(false);
« no previous file with comments | « no previous file | ash/wm/maximize_mode/maximize_mode_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698