Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Start Menu and Desktop is already handled by the installer.

And the Start Menu pins folder doesn't exist after Win7 (and Chrome has
been doing this for long enough that all Win7 Start Menu pins have sure
been migrated by now -- and even if not I don't think there is a failure
mode as the app ids that matter at runtime are the taskbar one and the
chrome window's, it was probably always useless to migrate start menu
pins...).

BUG=577697
TBR=sky@chromium.org

Committed: https://crrev.com/88257b623292f90c9dd33e98e5c9e0c241fb97fd
Cr-Commit-Position: refs/heads/master@{#369674}

[gab, 2016-01-14 17:19:44]

Patchset #1 (id:1) has been deleted

[gab, 2016-01-14 17:19:48]

Patchset #1 (id:20001) has been deleted

[gab, 2016-01-14 17:20:45]

gab@chromium.org changed reviewers:
+ grt@chromium.org

[gab, 2016-01-14 17:20:46]

Further cleanup which will make it a smaller port to setup.exe / Active Setup.

[grt (UTC plus 2), 2016-01-14 19:51:12]

lgtm w/ nits and a suggestion

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:160: static void
MigrateChromiumTaskbarPins();
wdyt of getting rid of "Chromium" here? or changing it to "Chrome"?

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:163: // have the appropriate AppUserModelId.
Also clears legacy dual_mode property
nit: "clears the legacy"

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
File chrome/browser/shell_integration_win.cc (right):

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration_win.cc:574: // |default_chromium_model_id|.
nit: close paren before terminating period

[gab, 2016-01-15 02:27:22]

Thanks, comments addressed.

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
File chrome/browser/shell_integration.h (right):

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:160: static void
MigrateChromiumTaskbarPins();
On 2016/01/14 19:51:12, grt wrote:
> wdyt of getting rid of "Chromium" here? or changing it to "Chrome"?

Done.

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration.h:163: // have the appropriate AppUserModelId.
Also clears legacy dual_mode property
On 2016/01/14 19:51:12, grt wrote:
> nit: "clears the legacy"

Done.

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
File chrome/browser/shell_integration_win.cc (right):

https://codereview.chromium.org/1588733005/diff/40001/chrome/browser/shell_in...
chrome/browser/shell_integration_win.cc:574: // |default_chromium_model_id|.
On 2016/01/14 19:51:12, grt wrote:
> nit: close paren before terminating period

Done.

[gab, 2016-01-15 02:27:51]

gab@chromium.org changed reviewers:
+ sky@chromium.org

[gab, 2016-01-15 02:27:51]

TBR sky for shell_integration.h (#ifdef(OS_WIN) only change and OWNER approval
already in for the _win.cc side) and related TODO in
startup_browser_creator_impl.cc

[gab, 2016-01-15 02:28:03]

Description was changed from

==========
Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Start Menu and Desktop is already handled by the installer.

And the Start Menu pins folder doesn't exist after Win7 (and Chrome has
been doing this for long enough that all Win7 Start Menu pins have sure
been migrated by now -- and even if not I don't think there is a failure
mode as the app ids that matter at runtime are the taskbar one and the
chrome window's, it was probably always useless to migrate start menu
pins...).

BUG=577697
==========

to

==========
Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Start Menu and Desktop is already handled by the installer.

And the Start Menu pins folder doesn't exist after Win7 (and Chrome has
been doing this for long enough that all Win7 Start Menu pins have sure
been migrated by now -- and even if not I don't think there is a failure
mode as the app ids that matter at runtime are the taskbar one and the
chrome window's, it was probably always useless to migrate start menu
pins...).

BUG=577697
TBR=sky@chromium.org
==========

[gab, 2016-01-15 02:28:07]

The CQ bit was checked by gab@chromium.org

[gab, 2016-01-15 02:28:07]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1588733005/#ps60001
(title: "review:grt")

[commit-bot: I haz the power, 2016-01-15 02:28:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1588733005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1588733005/60001

[commit-bot: I haz the power, 2016-01-15 03:19:26]

Description was changed from

==========
Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Start Menu and Desktop is already handled by the installer.

And the Start Menu pins folder doesn't exist after Win7 (and Chrome has
been doing this for long enough that all Win7 Start Menu pins have sure
been migrated by now -- and even if not I don't think there is a failure
mode as the app ids that matter at runtime are the taskbar one and the
chrome window's, it was probably always useless to migrate start menu
pins...).

BUG=577697
TBR=sky@chromium.org
==========

to

==========
Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Start Menu and Desktop is already handled by the installer.

And the Start Menu pins folder doesn't exist after Win7 (and Chrome has
been doing this for long enough that all Win7 Start Menu pins have sure
been migrated by now -- and even if not I don't think there is a failure
mode as the app ids that matter at runtime are the taskbar one and the
chrome window's, it was probably always useless to migrate start menu
pins...).

BUG=577697
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-01-15 03:19:27]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-01-15 03:20:36]

Description was changed from

==========
Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Start Menu and Desktop is already handled by the installer.

And the Start Menu pins folder doesn't exist after Win7 (and Chrome has
been doing this for long enough that all Win7 Start Menu pins have sure
been migrated by now -- and even if not I don't think there is a failure
mode as the app ids that matter at runtime are the taskbar one and the
chrome window's, it was probably always useless to migrate start menu
pins...).

BUG=577697
TBR=sky@chromium.org
==========

to

==========
Reduce MigrateChromiumShortcuts to only handling taskbar pins.

Start Menu and Desktop is already handled by the installer.

And the Start Menu pins folder doesn't exist after Win7 (and Chrome has
been doing this for long enough that all Win7 Start Menu pins have sure
been migrated by now -- and even if not I don't think there is a failure
mode as the app ids that matter at runtime are the taskbar one and the
chrome window's, it was probably always useless to migrate start menu
pins...).

BUG=577697
TBR=sky@chromium.org

Committed: https://crrev.com/88257b623292f90c9dd33e98e5c9e0c241fb97fd
Cr-Commit-Position: refs/heads/master@{#369674}
==========

[commit-bot: I haz the power, 2016-01-15 03:20:39]

Patchset 2 (id:??) landed as
https://crrev.com/88257b623292f90c9dd33e98e5c9e0c241fb97fd
Cr-Commit-Position: refs/heads/master@{#369674}