Reduce MigrateChromiumShortcuts to only handling taskbar pins.

chrome/browser/shell_integration.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SHELL_INTEGRATION_H_
 #define CHROME_BROWSER_SHELL_INTEGRATION_H_
 
 #include <string>
 
 #include "base/files/file_path.h"
@@ skipping 137 matching lines @@
 
   // Generates an application user model ID (AppUserModelId) for Chromium by
   // calling GetAppModelIdForProfile() with ShellUtil::GetAppId() as app_name.
   static base::string16 GetChromiumModelIdForProfile(
       const base::FilePath& profile_path);
 
   // Get the AppUserModelId for the App List, for the profile in |profile_path|.
   static base::string16 GetAppListAppModelIdForProfile(
       const base::FilePath& profile_path);
 
-  // Migrates existing chrome shortcuts by tagging them with correct app id.
+  // Migrates existing chrome taskbar pins by tagging them with correct app id.
   // see http://crbug.com/28104
-  static void MigrateChromiumShortcuts();
+  static void MigrateChromiumTaskbarPins();

[grt (UTC plus 2), 2016/01/14 19:51:12]

wdyt of getting rid of "Chromium" here? or changing it to "Chrome"?

[gab, 2016/01/15 02:27:22]

Done.

 
   // Migrates all shortcuts in |path| which point to |chrome_exe| such that they
-  // have the appropriate AppUserModelId. Also clears the dual_mode property
-  // from shortcuts that previously had it if requested by |clear_dual_mode|.
+  // have the appropriate AppUserModelId. Also clears legacy dual_mode property

[grt (UTC plus 2), 2016/01/14 19:51:12]

nit: "clears the legacy"

[gab, 2016/01/15 02:27:22]

Done.

+  // from shortcuts with the default chrome app id.
   // Returns the number of shortcuts migrated.
   // This method should not be called prior to Windows 7.
   // This method is only public for the sake of tests and shouldn't be called
   // externally otherwise.
   static int MigrateShortcutsInPathInternal(const base::FilePath& chrome_exe,
-                                            const base::FilePath& path,
-                                            bool clear_dual_mode);
+                                            const base::FilePath& path);
 
   // Returns the path to the Start Menu shortcut for the given Chrome.
   static base::FilePath GetStartMenuShortcut(const base::FilePath& chrome_exe);
 #endif  // defined(OS_WIN)
 
 #if !defined(OS_WIN)
   // TODO(calamity): replace with
   // BrowserDistribution::GetStartMenuShortcutSubfolder() once
   // BrowserDistribution is cross-platform.
   // Gets the name of the Chrome Apps menu folder in which to place app
@@ skipping 220 matching lines @@
     // Returns the histogram prefix for DefaultProtocolClientWorker.
     const char* GetHistogramPrefix() override;
 
     std::string protocol_;
 
     DISALLOW_COPY_AND_ASSIGN(DefaultProtocolClientWorker);
   };
 };
 
 #endif  // CHROME_BROWSER_SHELL_INTEGRATION_H_