Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 158873002: Revert of Move quota module to oilpan (Closed)

Created:
6 years, 10 months ago by dstockwell
Modified:
6 years, 10 months ago
CC:
blink-reviews, kinuko, oilpan-reviews, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Move quota module to oilpan (https://codereview.chromium.org/158133003/) Reason for revert: Broke the Oilpan build. See: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Oilpan/builds/386/steps/compile/logs/stdio Original issue's description: > Move quota module to oilpan > > This moves the storage quota interfaces to oilpan, using transition > types. > > Mostly regular, apart from one one interface (DeprecatedStorageQuota) > being used from both a main world and worker context, requiring thread > affinity defaults to be overridden for its class. > > R=haraken@chromium.org > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166819 TBR=haraken@chromium.org,ager@chromium.org,zerny@chromium.org,kinuko@chromium.org,tkent@chromium.org,sigbjornf@opera.com NOTREECHECKS=true NOTRY=true BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166821

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -63 lines) Patch
M Source/modules/quota/DOMWindowQuota.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.h View 2 chunks +6 lines, -10 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.cpp View 2 chunks +0 lines, -8 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageInfo.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.h View 3 chunks +3 lines, -10 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/quota/DeprecatedStorageQuota.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/quota/NavigatorStorageQuota.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/modules/quota/StorageInfo.h View 1 chunk +3 lines, -7 lines 0 comments Download
M Source/modules/quota/StorageInfo.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/quota/StorageInfo.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/quota/StorageQuota.h View 3 chunks +3 lines, -7 lines 0 comments Download
M Source/modules/quota/StorageQuota.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/modules/quota/StorageQuota.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/quota/WorkerNavigatorStorageQuota.h View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dstockwell
Created Revert of Move quota module to oilpan
6 years, 10 months ago (2014-02-10 11:50:47 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/158873002/1
6 years, 10 months ago (2014-02-10 11:50:56 UTC) #2
commit-bot: I haz the power
Change committed as 166821
6 years, 10 months ago (2014-02-10 11:51:15 UTC) #3
sof
Thanks for the revert, sorry about the mess. Will set up a local Windows oilpan ...
6 years, 10 months ago (2014-02-10 11:57:19 UTC) #4
sof
6 years, 10 months ago (2014-02-10 14:17:05 UTC) #5
Message was sent while issue was closed.
On 2014/02/10 11:57:19, sof wrote:
> Thanks for the revert, sorry about the mess.
> 
> Will set up a local Windows oilpan build.

Accidental CL interaction; the reason for the compilation breakage was the
revert of the serviceworker/ changes by

  https://codereview.chromium.org/158583002

which included some ScriptPromiseResolver.h RawPtr<> overloads that this quota/
CL depends on.

I'll put up the ScriptPromiseResolver.h changes in a separate CL.

Powered by Google App Engine
This is Rietveld 408576698