Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 158583002: Revert 166694 "Move serviceworker/ module to oilpan" (Closed)

Created:
6 years, 10 months ago by haraken
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Visibility:
Public.

Description

Revert 166694 "Move serviceworker/ module to oilpan" We decided not to move ServiceWorker to oilpan at the moment, since ServiceWorker is actively being developed and oilpan changes will confuse the development. We will get back to ServiceWorker later. > Move serviceworker/ module to oilpan > > - This CL doesn't move InstallEvent and InstallPhaseEvent since we need to move Event first. > > - This CL doesn't move ServiceWorkerGlobalScope since we need to move WorkerGlobalScope first. > > - This CL doesn't move ServiceWorkerThread since we need to move WorkerThread first. > > BUG=340522 > TBR=abarth (for web/) > > Review URL: https://codereview.chromium.org/153083006 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -45 lines) Patch
M trunk/Source/bindings/v8/ScriptPromiseResolver.h View 3 chunks +0 lines, -12 lines 0 comments Download
M trunk/Source/modules/serviceworkers/InstallEvent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/modules/serviceworkers/InstallEvent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M trunk/Source/modules/serviceworkers/InstallPhaseEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M trunk/Source/modules/serviceworkers/InstallPhaseEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M trunk/Source/modules/serviceworkers/ServiceWorker.h View 2 chunks +4 lines, -8 lines 0 comments Download
M trunk/Source/modules/serviceworkers/ServiceWorker.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/Source/modules/serviceworkers/ServiceWorker.idl View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/Source/modules/serviceworkers/WaitUntilObserver.h View 3 chunks +3 lines, -7 lines 0 comments Download
M trunk/Source/modules/serviceworkers/WaitUntilObserver.cpp View 3 chunks +5 lines, -7 lines 0 comments Download
M trunk/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
6 years, 10 months ago (2014-02-10 01:14:01 UTC) #1
haraken
6 years, 10 months ago (2014-02-10 01:14:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r166773.

Powered by Google App Engine
This is Rietveld 408576698