Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1588693002: Revert of Storing raw audio sink for default audio track. (Closed)

Created:
4 years, 11 months ago by Taylor Brandstetter
Modified:
4 years, 11 months ago
CC:
webrtc-reviews_webrtc.org
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Storing raw audio sink for default audio track. (patchset #7 id:120001 of https://codereview.chromium.org/1551813002/ ) Reason for revert: tommi pointed out that using a refptr for the sink may cause issues. Will reland with a slightly different approach. Original issue's description: > Storing raw audio sink for default audio track. > > BUG=webrtc:5250 > > Committed: https://crrev.com/e591f9377f33f3f725a30faecd1bef1a71fa6b99 > Cr-Commit-Position: refs/heads/master@{#11230} TBR=pthatcher@webrtc.org,solenberg@webrtc.org,pbos@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5250 Committed: https://crrev.com/2d110be77f14cab0bb51efe8b61d9c7a967d04cb Cr-Commit-Position: refs/heads/master@{#11241}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -135 lines) Patch
M talk/app/webrtc/mediastreamprovider.h View 2 chunks +2 lines, -2 lines 0 comments Download
M talk/app/webrtc/peerconnectioninterface_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M talk/app/webrtc/remoteaudiosource.cc View 1 chunk +2 lines, -1 line 0 comments Download
M talk/app/webrtc/rtpsenderreceiver_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M talk/app/webrtc/webrtcsession.h View 1 chunk +2 lines, -3 lines 0 comments Download
M talk/app/webrtc/webrtcsession.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M talk/media/base/fakemediaengine.h View 2 chunks +3 lines, -3 lines 0 comments Download
M talk/media/base/mediachannel.h View 1 chunk +1 line, -1 line 0 comments Download
M talk/media/webrtc/fakewebrtccall.h View 2 chunks +2 lines, -6 lines 0 comments Download
M talk/media/webrtc/fakewebrtccall.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.h View 2 chunks +1 line, -3 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine.cc View 3 chunks +4 lines, -13 lines 0 comments Download
M talk/media/webrtc/webrtcvoiceengine_unittest.cc View 3 chunks +0 lines, -62 lines 0 comments Download
M talk/session/media/channel.h View 1 chunk +2 lines, -3 lines 0 comments Download
M talk/session/media/channel.cc View 2 chunks +15 lines, -3 lines 0 comments Download
M webrtc/audio/audio_receive_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M webrtc/audio/audio_sink.h View 1 chunk +1 line, -3 lines 0 comments Download
M webrtc/audio_receive_stream.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.h View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Taylor Brandstetter
Created Revert of Storing raw audio sink for default audio track.
4 years, 11 months ago (2016-01-13 20:00:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588693002/1
4 years, 11 months ago (2016-01-13 20:00:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 20:00:29 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 20:00:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2d110be77f14cab0bb51efe8b61d9c7a967d04cb
Cr-Commit-Position: refs/heads/master@{#11241}

Powered by Google App Engine
This is Rietveld 408576698