Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1745)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.h

Issue 1588543004: Remove paintInvalidationRect from display item client invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.h
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
index 627b16a3e17b9918e7e57656524c8c5411a14459..e7718a2b3514f5e527c27e2359487769dc0972c0 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
@@ -10,7 +10,6 @@
#include "platform/geometry/IntRect.h"
#include "platform/geometry/LayoutPoint.h"
#include "platform/graphics/ContiguousContainer.h"
-#include "platform/graphics/PaintInvalidationReason.h"
#include "platform/graphics/paint/DisplayItem.h"
#include "platform/graphics/paint/DisplayItemList.h"
#include "platform/graphics/paint/PaintArtifact.h"
@@ -44,11 +43,7 @@ public:
// These methods are called during paint invalidation (or paint if SlimmingPaintV2 is on).
- // If |visualRect| is not nullptr, for slimming paint v1, it contains all pixels within the GraphicsLayer
- // which might be painted into by the display item client, in coordinate space of the GraphicsLayer.
- // TODO(pdr): define it for spv2.
- // |visualRect| can be nullptr if we know it's unchanged and PaintController has cached the previous value.
- void invalidate(const DisplayItemClient&, PaintInvalidationReason, const IntRect* visualRect);
+ void invalidate(const DisplayItemClient&);
void invalidateUntracked(const DisplayItemClient&);
void invalidateAll();
@@ -197,8 +192,6 @@ private:
void updateValidlyCachedClientsIfNeeded() const;
- void invalidateClient(const DisplayItemClient&);
-
#ifndef NDEBUG
WTF::String displayItemListAsDebugString(const DisplayItemList&) const;
#endif

Powered by Google App Engine
This is Rietveld 408576698