Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp

Issue 1588543004: Remove paintInvalidationRect from display item client invalidation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
index 2bd50f9f069be0fbb67935efaa0307b0bfae05d1..dec4f13d86169a3ddd29272fc70d2edabc3aaea7 100644
--- a/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
@@ -116,16 +116,7 @@ void PaintController::endScope()
endSkippingCache();
}
-void PaintController::invalidate(const DisplayItemClient& client, PaintInvalidationReason paintInvalidationReason, const IntRect* visualRect)
-{
- invalidateClient(client);
-
- if (visualRect) {
- // TODO(wkorman): cache visualRect for the client.
- }
-}
-
-void PaintController::invalidateClient(const DisplayItemClient& client)
+void PaintController::invalidate(const DisplayItemClient& client)
{
#if ENABLE(ASSERT)
// Slimming paint v1 CompositedLayerMapping may invalidate client on extra layers.
@@ -169,7 +160,7 @@ bool PaintController::clientCacheIsValid(const DisplayItemClient& client) const
void PaintController::invalidatePaintOffset(const DisplayItemClient& client)
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintOffsetCachingEnabled());
- invalidateClient(client);
+ invalidate(client);
#if ENABLE(ASSERT)
ASSERT(!paintOffsetWasInvalidated(client));

Powered by Google App Engine
This is Rietveld 408576698