Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: sdk/lib/_internal/pub/lib/src/io.dart

Issue 15883003: Remove ProcessOptions and make the options named arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments cleanup. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/pub/lib/src/io.dart
diff --git a/sdk/lib/_internal/pub/lib/src/io.dart b/sdk/lib/_internal/pub/lib/src/io.dart
index 122bcf0c8edc260e535eca5148b87e276a3bdcbc..f0f83c954bf804325d56259a2a6a098cf205f66a 100644
--- a/sdk/lib/_internal/pub/lib/src/io.dart
+++ b/sdk/lib/_internal/pub/lib/src/io.dart
@@ -592,19 +592,12 @@ Future _doProcess(Function fn, String executable, List<String> args,
executable = "cmd";
}
- final options = new ProcessOptions();
- if (workingDir != null) {
- options.workingDirectory = workingDir;
- }
-
- if (environment != null) {
- options.environment = new Map.from(Platform.environment);
- environment.forEach((key, value) => options.environment[key] = value);
- }
-
log.process(executable, args);
- return fn(executable, args, options);
+ return fn(executable,
+ args,
+ workingDirectory: workingDir,
+ environment: environment);
}
/// Wraps [input] to provide a timeout. If [input] completes before

Powered by Google App Engine
This is Rietveld 408576698