Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/io_patch.dart

Issue 15883003: Remove ProcessOptions and make the options named arguments. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comments cleanup. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/lib/io_patch.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/io_patch.dart b/sdk/lib/_internal/compiler/implementation/lib/io_patch.dart
index 61120ea660cf4a34169b596f84a449e7d719857b..feb70091d522521d7dc50fa9ffe338597ea9f013 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/io_patch.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/io_patch.dart
@@ -186,15 +186,23 @@ patch class _ProcessUtils {
}
patch class Process {
- patch static Future<Process> start(String executable,
- List<String> arguments,
- [ProcessOptions options]) {
+ patch static Future<Process> start(
+ String executable,
+ List<String> arguments,
+ {String workingDirectory,
+ Map<String, String> environment,
+ bool runInShell: false}) {
throw new UnsupportedError("Process.start");
}
- patch static Future<ProcessResult> run(String executable,
- List<String> arguments,
- [ProcessOptions options]) {
+ patch static Future<ProcessResult> run(
+ String executable,
+ List<String> arguments,
+ {String workingDirectory,
+ Map<String, String> environment,
+ bool runInShell: false,
+ Encoding stdoutEncoding: Encoding.SYSTEM,
+ Encoding stderrEncoding: Encoding.SYSTEM}) {
throw new UnsupportedError("Process.run");
}
}

Powered by Google App Engine
This is Rietveld 408576698