Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1588293005: Drop "current_code" from compiler API. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Drop "current_code" from compiler API. This removes the need to pass in the current unoptimized code when requesting optimized code for a function. Note that the notion of unoptimized code becomes moot when optimizing from the interpreter bytecode, hence the API should not encode such a dependency. R=bmeurer@chromium.org Committed: https://crrev.com/8041a753cae6c8ddfd1c481749e84c81bd2ae561 Cr-Commit-Position: refs/heads/master@{#33353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -9 lines) Patch
M src/compiler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 2 chunks +2 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588293005/1
4 years, 11 months ago (2016-01-15 14:16:21 UTC) #2
Michael Starzinger
4 years, 11 months ago (2016-01-15 14:32:25 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-15 14:57:50 UTC) #5
Benedikt Meurer
LGTM from my side
4 years, 11 months ago (2016-01-15 15:12:19 UTC) #6
Michael Starzinger
Yang thinks it should be fine from a concurrent-OSR perspective as well. Will land today.
4 years, 11 months ago (2016-01-18 09:00:13 UTC) #8
Yang
On 2016/01/18 09:00:13, Michael Starzinger wrote: > Yang thinks it should be fine from a ...
4 years, 11 months ago (2016-01-18 09:01:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588293005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588293005/1
4 years, 11 months ago (2016-01-18 09:59:33 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-18 10:23:54 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-18 10:24:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8041a753cae6c8ddfd1c481749e84c81bd2ae561
Cr-Commit-Position: refs/heads/master@{#33353}

Powered by Google App Engine
This is Rietveld 408576698