Issue 158823002: Experimental parser: refactor TransitionKey to use Term

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 158823002: Experimental parser: refactor TransitionKey to use Term (Closed)

Created:
6 years, 10 months ago by dcarney

Modified:
6 years, 10 months ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: refactor TransitionKey to use Term TBR=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=19276

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+526 lines, -325 lines)			Patch
M	tools/lexer_generator/action.py	View		4 chunks	+8 lines, -7 lines	0 comments	Download
M	tools/lexer_generator/automata_test.py	View		1 chunk	+60 lines, -52 lines	0 comments	Download
M	tools/lexer_generator/code_generator.py	View		2 chunks	+3 lines, -4 lines	0 comments	Download
M	tools/lexer_generator/generator.py	View		3 chunks	+22 lines, -0 lines	0 comments	Download
M	tools/lexer_generator/regex_parser.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/lexer_generator/transition_key_test.py	View	1 2 3	2 chunks	+69 lines, -6 lines	0 comments	Download
M	tools/lexer_generator/transition_keys.py	View	1 2	15 chunks	+363 lines, -255 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dcarney

Committed patchset #4 manually as r19276 (presubmit successful).

6 years, 10 months ago (2014-02-11 12:22:26 UTC) #1

marja

6 years, 10 months ago (2014-02-11 18:17:06 UTC) #2

Message was sent while issue was closed.

This broke some stuff:

=== lexer/cornercases/file-with-zero ===
--- stdout ---
MISMATCH:
Expected:       STRING at (1616, 1665) 74 68 69 73 20 66 69 6c 65 20 68 61 73 20
61 20 7a 65 72 6f 20 63 68 61 72 61 63 74 65 72 00 20 69 6e 73 69 64 65 20 61 20
73 74 72 69 6e 67 (is ascii: 1) (last octal start: -1)
Actual:        ILLEGAL at (1616, 1647) (last octal start: -1)
Command:
/mnt/data/b/build/slave/v8-linux-experimental-parser-debug/build/v8/out/Debug/lexer-shell
--nobreak-on-abort --nodead-code-elimination --nofold-constants
--enable-slow-asserts --debug-code --verify-heap
/mnt/data/b/build/slave/v8-linux-experimental-parser-debug/build/v8/test/lexer/cornercases/file-with-zero.js

Expand Messages | Collapse Messages