tools/lexer_generator/code_generator.py - Issue 158823002: Experimental parser: refactor TransitionKey to use Term

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/lexer_generator/code_generator.py

Issue 158823002: Experimental parser: refactor TransitionKey to use Term (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/parser

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/lexer_generator/code_generator.py

diff --git a/tools/lexer_generator/code_generator.py b/tools/lexer_generator/code_generator.py

index c542ec56a08fd33cb838e0ed103bea3776a394a5..85b98c5a56841847dc341fd24b1c12fb6a9dc7ea 100644

--- a/tools/lexer_generator/code_generator.py

+++ b/tools/lexer_generator/code_generator.py

@@ -66,9 +66,8 @@ class CodeGenerator:

# generate ordered transitions

transitions = map(lambda (k, v) : (k, v.node_number()),

state.key_state_iter())

- def cmp(left, right):

- return TransitionKey.canonical_compare(left[0], right[0])

- transitions = sorted(transitions, cmp)

+ transitions = sorted(

+ transitions, cmp = TransitionKey.compare, key = lambda x : x[0])

# map transition keys to disjoint ranges and collect stats

disjoint_keys = []

unique_transitions = {}

@@ -207,7 +206,7 @@ class CodeGenerator:

return

encoding = self.__dfa.encoding()

catch_all = 'non_primary_everything_else'

- all_classes = set(encoding.class_name_iter())

+ all_classes = set(encoding.named_range_key_iter())

call_classes = all_classes - set([catch_all])

def remap_transition(class_name):

if class_name in call_classes:

« no previous file with comments | « tools/lexer_generator/automata_test.py ('k') | tools/lexer_generator/generator.py » ('j') | no next file with comments »