Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 1587983004: these _procs_arm are not used when we have NEON (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

these _procs_arm are not used when we have NEON BUG=skia:4798 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1587983004 CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot Committed: https://skia.googlesource.com/skia/+/349dcc99b69f27ab834232796371e678625078e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/opts/SkBlitRow_opts_arm.cpp View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587983004/1
4 years, 11 months ago (2016-01-14 16:54:27 UTC) #3
msarett
lgtm
4 years, 11 months ago (2016-01-14 17:00:51 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 17:11:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587983004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587983004/1
4 years, 11 months ago (2016-01-14 19:16:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/349dcc99b69f27ab834232796371e678625078e0
4 years, 11 months ago (2016-01-14 19:16:49 UTC) #11
mtklein
4 years, 11 months ago (2016-01-14 21:49:01 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1589633005/ by mtklein@google.com.

The reason for reverting is: Breaks Chrome roll:

https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro....

Powered by Google App Engine
This is Rietveld 408576698