Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1587893003: git cl try: omit triggered bots from cq.cfg default list (Closed)

Created:
4 years, 11 months ago by Michael Achenbach
Modified:
4 years, 11 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

git cl try: omit triggered bots from cq.cfg default list BUG=522909, 565952 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298261

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M commit_queue.py View 1 2 chunks +9 lines, -3 lines 0 comments Download
M git_cl.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Michael Achenbach
PTAL
4 years, 11 months ago (2016-01-14 07:59:11 UTC) #3
Sergiy Byelozyorov
lgtm
4 years, 11 months ago (2016-01-14 09:34:08 UTC) #4
tandrii(chromium)
https://codereview.chromium.org/1587893003/diff/1/commit_queue.py File commit_queue.py (right): https://codereview.chromium.org/1587893003/diff/1/commit_queue.py#newcode108 commit_queue.py:108: def get_master_builder_map(config_path): how about adding here "include_experimental=True, include_triggered=True" so ...
4 years, 11 months ago (2016-01-14 09:36:06 UTC) #5
Michael Achenbach
https://codereview.chromium.org/1587893003/diff/1/commit_queue.py File commit_queue.py (right): https://codereview.chromium.org/1587893003/diff/1/commit_queue.py#newcode108 commit_queue.py:108: def get_master_builder_map(config_path): On 2016/01/14 09:36:06, tandrii(chromium) wrote: > how ...
4 years, 11 months ago (2016-01-14 09:56:04 UTC) #6
Sergiy Byelozyorov
still lgtm
4 years, 11 months ago (2016-01-14 09:58:06 UTC) #7
tandrii(chromium)
lgtm
4 years, 11 months ago (2016-01-14 10:04:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587893003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587893003/20001
4 years, 11 months ago (2016-01-14 10:06:30 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 10:10:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298261

Powered by Google App Engine
This is Rietveld 408576698