Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: commit_queue.py

Issue 1587893003: git cl try: omit triggered bots from cq.cfg default list (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Review Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit_queue.py
diff --git a/commit_queue.py b/commit_queue.py
index c950db68cdd6a290ea2a2434d38b97b16803b664..7adcc975c09a0ca55d16eea55c9f909d6b014900 100755
--- a/commit_queue.py
+++ b/commit_queue.py
@@ -105,7 +105,8 @@ def set_commit(obj, issue, flag):
_apply_on_issue(_set_commit, obj, issue)
-def get_master_builder_map(config_path):
+def get_master_builder_map(
+ config_path, include_experimental=True, include_triggered=True):
"""Returns a map of master -> [builders] from cq config."""
with open(config_path) as config_file:
cq_config = config_file.read()
@@ -117,8 +118,13 @@ def get_master_builder_map(config_path):
for bucket in config.verifiers.try_job.buckets:
masters.setdefault(bucket.name, [])
for builder in bucket.builders:
- if not builder.HasField('experiment_percentage'):
- masters[bucket.name].append(builder.name)
+ if (not include_experimental and
+ builder.HasField('experiment_percentage')):
+ continue
+ if (not include_triggered and
+ builder.HasField('triggered_by')):
+ continue
+ masters[bucket.name].append(builder.name)
return masters
« no previous file with comments | « no previous file | git_cl.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698