Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1587873004: Tone down the hover effect on mousing over background tabs. (Closed)

Created:
4 years, 11 months ago by Peter Kasting
Modified:
4 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Tone down the hover effect on mousing over background tabs. * Reduce the peak opacity of the highlight from 50% to 25%. * Reduce the radius from (tab width / 3) to (tab width / 4). Add a 16 px minimum radius to keep things from getting too tiny on very narrow tabs. This also removes the "radius > 0" check, which should have never been false anyway, as that would require a tab width of 0, in which case we wouldn't be drawing anything. In MD, incognito windows have very dark tabs, on which the previous highlight is a bit out of control. This makes things feel more manageable. BUG=none TEST=none Committed: https://crrev.com/f50089343ce1c5854cc498dce2047de7b0db2823 Cr-Commit-Position: refs/heads/master@{#369672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/ui/views/tabs/tab.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/views/controls/glow_hover_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Peter Kasting
4 years, 11 months ago (2016-01-15 00:44:25 UTC) #2
sky
LGTM
4 years, 11 months ago (2016-01-15 00:57:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587873004/1
4 years, 11 months ago (2016-01-15 01:41:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/165606)
4 years, 11 months ago (2016-01-15 02:35:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587873004/1
4 years, 11 months ago (2016-01-15 02:41:51 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 03:17:17 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 03:18:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f50089343ce1c5854cc498dce2047de7b0db2823
Cr-Commit-Position: refs/heads/master@{#369672}

Powered by Google App Engine
This is Rietveld 408576698