Update Clang build script and gyp file for 3.8.0 version bump

Update Clang build script and gyp file for 3.8.0 version bump

BUG=510304
Committed: https://crrev.com/1fc27722fcfed8dc4b8e6e1c98062d50de36e2a1
Cr-Commit-Position: refs/heads/master@{#338942}

[hans, 2015-07-15 18:00:18]

hans@chromium.org changed reviewers:
+ thakis@chromium.org

[hans, 2015-07-15 18:00:18]

Please take a look.

[Nico, 2015-07-15 18:17:22]

what about all the isolate files? package.py?

[hans, 2015-07-15 18:26:15]

On 2015/07/15 18:17:22, Nico wrote:
> what about all the isolate files? package.py?

package.py uses wildcards to get around the version nbr issue. E.g., it copies
files like "lib/clang/*/lib/darwin/*asan_osx*", and it does clobbered builts so
it will not get multiple versions.

It seems the only isolate file using the version is base/base.isolate. Are
.isolate files also using gyp? Can I do the same python trick there?

I now also found build/win/asan.gyp.. I'll update that.

[hans, 2015-07-15 18:53:45]

New attempt, updating asan.gyp and base.isolate.

[Nico, 2015-07-15 19:17:50]

https://codereview.chromium.org/1239653004/diff/60001/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/1239653004/diff/60001/base/base.isolate#newco...
base/base.isolate:39:
'../third_party/llvm-build/Release+Asserts/lib/clang/<!(python
<../tools/clang/scripts/update.py
--print-clang-version)/lib/windows/clang_rt.asan_dynamic-i386.dll',
isolate files aren't gyp files. I don't think <!() works here…

[hans, 2015-07-15 19:56:09]

New patch uploaded.

https://codereview.chromium.org/1239653004/diff/60001/base/base.isolate
File base/base.isolate (right):

https://codereview.chromium.org/1239653004/diff/60001/base/base.isolate#newco...
base/base.isolate:39:
'../third_party/llvm-build/Release+Asserts/lib/clang/<!(python
<../tools/clang/scripts/update.py
--print-clang-version)/lib/windows/clang_rt.asan_dynamic-i386.dll',
On 2015/07/15 19:17:50, Nico wrote:
> isolate files aren't gyp files. I don't think <!() works here…

:-(

New idea: let's just grab the whole lib dir, circumventing the whole version
issue. On my Windows box it's 10 MB.

[Nico, 2015-07-15 20:04:26]

lgtm

[hans, 2015-07-15 20:06:30]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-07-15 20:07:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239653004/80001

[commit-bot: I haz the power, 2015-07-15 23:07:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-15 23:08:00]

Patchset 5 (id:??) landed as
https://crrev.com/1fc27722fcfed8dc4b8e6e1c98062d50de36e2a1
Cr-Commit-Position: refs/heads/master@{#338942}

[Nico, 2015-07-16 17:50:01]

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:63: VERSION = '3.7.0'
This needs to be bumped to 3.8.0 too, as I just learned while trying to build a
new package :-(

[hans, 2015-07-16 17:51:04]

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:63: VERSION = '3.7.0'
On 2015/07/16 17:50:00, Nico wrote:
> This needs to be bumped to 3.8.0 too, as I just learned while trying to build
a
> new package :-(

Sorry, I should have put a TODO here too :(

[Nico, 2015-07-16 17:51:24]

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:63: VERSION = '3.7.0'
On 2015/07/16 17:50:00, Nico wrote:
> This needs to be bumped to 3.8.0 too, as I just learned while trying to build
a
> new package :-(

(it's only used when building clang, so it can be 3.8.0 unconditionally, it
doesn't have to be dependent on use_head_revision)

[hans, 2015-07-16 17:59:47]

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:63: VERSION = '3.7.0'
On 2015/07/16 17:51:23, Nico wrote:
> On 2015/07/16 17:50:00, Nico wrote:
> > This needs to be bumped to 3.8.0 too, as I just learned while trying to
build
> a
> > new package :-(
> 
> (it's only used when building clang, so it can be 3.8.0 unconditionally, it
> doesn't have to be dependent on use_head_revision)

I'm not following. It's also used by --print-clang-version, which determines
where gyp looks for asan runtimes, etc. So it needs to be in sync with the
revision that's used, no?

[Nico, 2015-07-16 18:02:14]

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
File tools/clang/scripts/update.py (right):

https://codereview.chromium.org/1239653004/diff/80001/tools/clang/scripts/upd...
tools/clang/scripts/update.py:63: VERSION = '3.7.0'
On 2015/07/16 17:59:47, hans wrote:
> On 2015/07/16 17:51:23, Nico wrote:
> > On 2015/07/16 17:50:00, Nico wrote:
> > > This needs to be bumped to 3.8.0 too, as I just learned while trying to
> build
> > a
> > > new package :-(
> > 
> > (it's only used when building clang, so it can be 3.8.0 unconditionally, it
> > doesn't have to be dependent on use_head_revision)
> 
> I'm not following. It's also used by --print-clang-version, which determines
> where gyp looks for asan runtimes, etc. So it needs to be in sync with the
> revision that's used, no?

Oh, right. It wasn't used before this CL though (I think). Nevermind then.

If I ever succeed in building a new clang/win package this can be 3.8.0
unconditionally anyways.