scheduler: Turn expensive task blocking into a finch trial

scheduler: Turn expensive task blocking into a finch trial

Turn expensive task blocking into a feature (finch trial) which is
disabled by default.

BUG=574343
Committed: https://crrev.com/819799e247d9b54a426b422cfda9ee422339c218
Cr-Commit-Position: refs/heads/master@{#369398}

[Sami, 2016-01-13 16:34:29]

Description was changed from

==========
scheduler: Turn expensive task blocking into a finch trial

Turn expensive task blocking into a feature (finch trial) which is
disabled by default.

BUG=574343
==========

to

==========
scheduler: Turn expensive task blocking into a finch trial

Turn expensive task blocking into a feature (finch trial) which is
disabled by default.

BUG=574343
==========

[Sami, 2016-01-13 16:34:29]

skyostil@chromium.org changed reviewers:
+ alexclarke@chromium.org

[alex clarke (OOO till 29th), 2016-01-13 17:18:30]

lgtm

https://codereview.chromium.org/1587663003/diff/1/components/scheduler/render...
File components/scheduler/renderer/renderer_scheduler.cc (right):

https://codereview.chromium.org/1587663003/diff/1/components/scheduler/render...
components/scheduler/renderer/renderer_scheduler.cc:52:
scheduler->SetExpensiveTaskBlockingAllowed(
Doesn't have to be this patch but perhaps we might want a command line flag to
disable this too. WDYT?

[Sami, 2016-01-13 17:25:46]

https://codereview.chromium.org/1587663003/diff/1/components/scheduler/render...
File components/scheduler/renderer/renderer_scheduler.cc (right):

https://codereview.chromium.org/1587663003/diff/1/components/scheduler/render...
components/scheduler/renderer/renderer_scheduler.cc:52:
scheduler->SetExpensiveTaskBlockingAllowed(
On 2016/01/13 17:18:30, alexclarke1 wrote:
> Doesn't have to be this patch but perhaps we might want a command line flag to
> disable this too. WDYT?

Conveniently this already hooks up to
--enable-features=... and --disable-features=... so things Just Work.

[Sami, 2016-01-13 17:25:50]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2016-01-13 17:26:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587663003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587663003/1

[commit-bot: I haz the power, 2016-01-13 18:10:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-13 18:10:58]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[Sami, 2016-01-13 18:25:39]

skyostil@chromium.org changed reviewers:
+ sievers@chromium.org

[Sami, 2016-01-13 18:26:23]

Daniel, can you check content/renderer/renderer_main.cc? I needed to move the
scheduler initialization later after base::FeatureList has been initialized.

[no sievers, 2016-01-13 21:39:26]

On 2016/01/13 18:26:23, Sami wrote:
> Daniel, can you check content/renderer/renderer_main.cc? I needed to move the
> scheduler initialization later after base::FeatureList has been initialized.

lgtm

[Sami, 2016-01-14 10:58:31]

The CQ bit was checked by skyostil@chromium.org

[Sami, 2016-01-14 10:58:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
alexclarke@chromium.org, sievers@chromium.org
Link to the patchset: https://codereview.chromium.org/1587663003/#ps40001
(title: "html_viewer fix.")

[commit-bot: I haz the power, 2016-01-14 10:58:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587663003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587663003/40001

[commit-bot: I haz the power, 2016-01-14 12:15:58]

Description was changed from

==========
scheduler: Turn expensive task blocking into a finch trial

Turn expensive task blocking into a feature (finch trial) which is
disabled by default.

BUG=574343
==========

to

==========
scheduler: Turn expensive task blocking into a finch trial

Turn expensive task blocking into a feature (finch trial) which is
disabled by default.

BUG=574343
==========

[commit-bot: I haz the power, 2016-01-14 12:16:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-14 12:18:40]

Description was changed from

==========
scheduler: Turn expensive task blocking into a finch trial

Turn expensive task blocking into a feature (finch trial) which is
disabled by default.

BUG=574343
==========

to

==========
scheduler: Turn expensive task blocking into a finch trial

Turn expensive task blocking into a feature (finch trial) which is
disabled by default.

BUG=574343

Committed: https://crrev.com/819799e247d9b54a426b422cfda9ee422339c218
Cr-Commit-Position: refs/heads/master@{#369398}
==========

[commit-bot: I haz the power, 2016-01-14 12:18:41]

Patchset 3 (id:??) landed as
https://crrev.com/819799e247d9b54a426b422cfda9ee422339c218
Cr-Commit-Position: refs/heads/master@{#369398}