Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Unified Diff: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 1587663003: scheduler: Turn expensive task blocking into a finch trial (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: html_viewer fix. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | content/renderer/renderer_main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index 4e7dfc59805199af4315e73e400cf3c01934f748..31b24a88b2c090b51da46b504bb692f9d7c6677c 100644
--- a/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/components/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -2231,6 +2231,32 @@ TEST_F(RendererSchedulerImplTest, ExpensiveTimerTaskBlocked) {
EXPECT_THAT(run_order, testing::ElementsAre(std::string("D1")));
}
+TEST_F(RendererSchedulerImplTest, ExpensiveTimerTaskNotBlockedIfDisallowed) {
+ std::vector<std::string> run_order;
+
+ EnableTaskBlocking();
+ scheduler_->SetExpensiveTaskBlockingAllowed(false);
+ scheduler_->SetHasVisibleRenderWidgetWithTouchHandler(true);
+ DoMainFrame();
+ SimulateExpensiveTasks(timer_task_runner_);
+ ForceTouchStartToBeExpectedSoon();
+
+ scheduler_->DidHandleInputEventOnCompositorThread(
+ FakeInputEvent(blink::WebInputEvent::GestureFlingStart),
+ RendererScheduler::InputEventState::EVENT_FORWARDED_TO_MAIN_THREAD);
+ PostTestTasks(&run_order, "T1 D1");
+ RunUntilIdle();
+
+ EXPECT_EQ(UseCase::MAIN_THREAD_GESTURE,
+ ForceUpdatePolicyAndGetCurrentUseCase());
+ EXPECT_TRUE(HaveSeenABeginMainframe());
+ EXPECT_FALSE(LoadingTasksSeemExpensive());
+ EXPECT_TRUE(TimerTasksSeemExpensive());
+ EXPECT_TRUE(TouchStartExpectedSoon());
+ EXPECT_THAT(run_order, testing::ElementsAre(std::string("T1"),
+ std::string("D1")));
+}
+
TEST_F(RendererSchedulerImplTest,
ExpensiveTimerTaskBlockedIfTouchStartNotSeen) {
std::vector<std::string> run_order;
« no previous file with comments | « components/scheduler/renderer/renderer_scheduler_impl.cc ('k') | content/renderer/renderer_main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698