Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1587513002: Using alternative_android_sdk_jar in process_resources, package_resources (Closed)

Created:
4 years, 11 months ago by michaelbai
Modified:
4 years, 11 months ago
Reviewers:
agrieve
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, mnaganov (inactive)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using alternative_android_sdk_jar in process_resources, package_resources BUG=576852 Committed: https://crrev.com/c58222a7a1486b36fb8718972a0e48a76b7174af Cr-Commit-Position: refs/heads/master@{#369287}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : remove android-sdk param #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -15 lines) Patch
M build/android/gyp/package_resources.py View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M build/android/gyp/process_resources.py View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M build/android/package_resources_action.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/config/android/internal_rules.gni View 1 2 4 chunks +20 lines, -4 lines 0 comments Download
M build/config/android/rules.gni View 3 chunks +3 lines, -0 lines 0 comments Download
M build/java.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M build/java_apk.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587513002/1
4 years, 11 months ago (2016-01-13 04:02:23 UTC) #2
michaelbai
4 years, 11 months ago (2016-01-13 05:09:28 UTC) #5
agrieve
On 2016/01/13 05:09:28, michaelbai wrote: Looks good overall, but I think it would simplify things ...
4 years, 11 months ago (2016-01-13 15:26:37 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587513002/40001
4 years, 11 months ago (2016-01-13 21:40:37 UTC) #8
michaelbai
Removed android-sdk, I were not sure if android_sdk_jar is always set.
4 years, 11 months ago (2016-01-13 21:41:26 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) ...
4 years, 11 months ago (2016-01-13 23:46:46 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587513002/40001
4 years, 11 months ago (2016-01-14 00:00:43 UTC) #13
agrieve
On 2016/01/14 00:00:43, commit-bot: I haz the power wrote: > Dry run: CQ is trying ...
4 years, 11 months ago (2016-01-14 00:57:03 UTC) #14
commit-bot: I haz the power
Dry run: Exceeded global retry quota
4 years, 11 months ago (2016-01-14 02:12:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587513002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587513002/40001
4 years, 11 months ago (2016-01-14 02:23:39 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-14 02:28:46 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 02:30:28 UTC) #22
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c58222a7a1486b36fb8718972a0e48a76b7174af
Cr-Commit-Position: refs/heads/master@{#369287}

Powered by Google App Engine
This is Rietveld 408576698