Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1889)

Unified Diff: build/config/android/internal_rules.gni

Issue 1587513002: Using alternative_android_sdk_jar in process_resources, package_resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove android-sdk param Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/package_resources_action.gypi ('k') | build/config/android/rules.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 444e3f62d2dc088b9316276fa8c04f8597f58347..8ae340c90cf792881e195b0400060bde010b0229 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -933,11 +933,18 @@ template("create_apk") {
_android_aapt_path = android_default_aapt_path
}
+ if (defined(invoker.alternative_android_sdk_jar)) {
+ _rebased_android_sdk_jar =
+ rebase_path(invoker.alternative_android_sdk_jar)
+ } else {
+ _rebased_android_sdk_jar = rebased_android_sdk_jar
+ }
+
args = [
"--depfile",
rebase_path(depfile, root_build_dir),
- "--android-sdk",
- rebased_android_sdk,
+ "--android-sdk-jar",
+ _rebased_android_sdk_jar,
"--aapt-path",
_android_aapt_path,
"--configuration-name=$android_configuration_name",
@@ -988,6 +995,7 @@ template("create_apk") {
package_resources_helper(_package_resources_target_name) {
forward_variables_from(invoker,
[
+ "alternative_android_sdk_jar",
"android_aapt_path",
"extensions_to_not_compress",
])
@@ -1035,6 +1043,7 @@ template("create_apk") {
package_resources_helper(_incremental_package_resources_target_name) {
forward_variables_from(invoker,
[
+ "alternative_android_sdk_jar",
"android_aapt_path",
"extensions_to_not_compress",
])
@@ -1780,11 +1789,18 @@ template("process_resources") {
_android_aapt_path = android_default_aapt_path
}
+ if (defined(invoker.alternative_android_sdk_jar)) {
+ _rebased_android_sdk_jar =
+ rebase_path(invoker.alternative_android_sdk_jar)
+ } else {
+ _rebased_android_sdk_jar = rebased_android_sdk_jar
+ }
+
args = [
"--depfile",
rebase_path(depfile, root_build_dir),
- "--android-sdk",
- rebase_path(android_sdk, root_build_dir),
+ "--android-sdk-jar",
+ _rebased_android_sdk_jar,
"--aapt-path",
_android_aapt_path,
"--android-manifest",
« no previous file with comments | « build/android/package_resources_action.gypi ('k') | build/config/android/rules.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698