Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: tests/language/abstract_runtime_error_test.dart

Issue 158733003: Fix language tests wrt. warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/language/abstract_runtime_error_test.dart
diff --git a/tests/language/abstract_runtime_error_test.dart b/tests/language/abstract_runtime_error_test.dart
index c408ec8b93e86c4e9e1f5c29c8445a349d8549b5..eb6a0ead724e90b8f50718c43f62e238fc706610 100644
--- a/tests/language/abstract_runtime_error_test.dart
+++ b/tests/language/abstract_runtime_error_test.dart
@@ -12,7 +12,7 @@ import "package:expect/expect.dart";
abstract class Interface {
- void foo();
+ void foo(); /// 03: static type warning
}
abstract class AbstractClass {
@@ -27,19 +27,19 @@ class NonAbstractClass implements Interface {
toString() => 'NonAbstractClass';
}
-Interface interface() => new Interface();
+Interface interface() => new Interface(); /// 01: static type warning
-AbstractClass abstractClass() => new AbstractClass();
+AbstractClass abstractClass() => new AbstractClass(); /// 02: static type warning
bool isAbstractClassInstantiationError(e) {
return e is AbstractClassInstantiationError;
}
void main() {
- Expect.throws(interface, isAbstractClassInstantiationError,
- "expected AbstractClassInstantiationError");
- Expect.throws(abstractClass, isAbstractClassInstantiationError,
- "expected AbstractClassInstantiationError");
+ Expect.throws(interface, isAbstractClassInstantiationError, /// 01: continued
+ "expected AbstractClassInstantiationError"); /// 01: continued
+ Expect.throws(abstractClass, isAbstractClassInstantiationError, /// 02: continued
+ "expected AbstractClassInstantiationError"); /// 02: continued
Expect.stringEquals('ConcreteSubclass', '${new ConcreteSubclass()}');
Expect.stringEquals('NonAbstractClass', '${new NonAbstractClass()}');
}

Powered by Google App Engine
This is Rietveld 408576698