Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tests/language/abstract_getter_test.dart

Issue 158733003: Fix language tests wrt. warnings. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/abstract_factory_constructor_test.dart ('k') | tests/language/abstract_runtime_error_test.dart » ('j') | tests/language/closure_type_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/abstract_getter_test.dart
diff --git a/tests/language/abstract_getter_test.dart b/tests/language/abstract_getter_test.dart
index 7befb6c452ae4088d257b5e2caf6d20015cf9880..4ec7038d2a2c3a0cccf0f18110c682cd91d561c7 100644
--- a/tests/language/abstract_getter_test.dart
+++ b/tests/language/abstract_getter_test.dart
@@ -7,7 +7,8 @@ import "package:expect/expect.dart";
// Test to ensure that an abstract getter is not mistaken for a field.
class Foo {
- get i; // Abstract.
+ // Intentionally abstract:
+ get i; /// 01: static type warning
karlklose 2014/02/13 14:01:42 I prefer two spaces before end-of-line comments. I
Johnni Winther 2014/02/14 09:46:47 Done.
}
class Bar {
@@ -16,9 +17,9 @@ class Bar {
noMethod(e) => e is NoSuchMethodError;
checkIt(f) {
- Expect.throws(() { f.i = 'hi'; }, noMethod);
- Expect.throws(() { print(f.i); }, noMethod);
- Expect.throws(() { print(f.i()); }, noMethod);
+ Expect.throws(() { f.i = 'hi'; }, noMethod); /// 01: continued
+ Expect.throws(() { print(f.i); }, noMethod); /// 01: continued
+ Expect.throws(() { print(f.i()); }, noMethod); /// 01: continued
}
main() {
« no previous file with comments | « tests/language/abstract_factory_constructor_test.dart ('k') | tests/language/abstract_runtime_error_test.dart » ('j') | tests/language/closure_type_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698