Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1587153003: [runtime] Migrate Object.getOwnPropertySymbols to C++. (Closed)

Created:
4 years, 11 months ago by Benedikt Meurer
Modified:
4 years, 11 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Migrate Object.getOwnPropertySymbols to C++. The Object.getOwnPropertySymbols() calls into C++ at least once on every possible path, so no point in having the JavaScript wrapper. Drive-by-cleanup: Also move Symbol.prototype creation to C++ as well. R=yangguo@chromium.org Committed: https://crrev.com/489e7e391525b2830fa45fce222f1e4695073fb2 Cr-Commit-Position: refs/heads/master@{#33318}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M src/bootstrapper.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/builtins.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M src/js/symbol.js View 4 chunks +0 lines, -17 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Benedikt Meurer
4 years, 11 months ago (2016-01-15 09:26:43 UTC) #1
Benedikt Meurer
Hey Yang, Simple refactoring. Please take a look. Thanks, Benedikt
4 years, 11 months ago (2016-01-15 09:27:28 UTC) #2
Yang
On 2016/01/15 09:27:28, Benedikt Meurer wrote: > Hey Yang, > > Simple refactoring. > Please ...
4 years, 11 months ago (2016-01-15 09:31:48 UTC) #3
Yang
On 2016/01/15 09:31:48, Yang wrote: > On 2016/01/15 09:27:28, Benedikt Meurer wrote: > > Hey ...
4 years, 11 months ago (2016-01-15 09:32:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587153003/1
4 years, 11 months ago (2016-01-15 09:50:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 09:51:48 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 09:52:34 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/489e7e391525b2830fa45fce222f1e4695073fb2
Cr-Commit-Position: refs/heads/master@{#33318}

Powered by Google App Engine
This is Rietveld 408576698