Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Unified Diff: src/js/symbol.js

Issue 1587153003: [runtime] Migrate Object.getOwnPropertySymbols to C++. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/symbol.js
diff --git a/src/js/symbol.js b/src/js/symbol.js
index 5be6e0168d7a2d2629340264fdfcf09b3db0de3b..a5d80a61801b6afe3b607b4db189299cdfe6e933 100644
--- a/src/js/symbol.js
+++ b/src/js/symbol.js
@@ -11,7 +11,6 @@
// -------------------------------------------------------------------
// Imports
-var GlobalObject = global.Object;
var GlobalSymbol = global.Symbol;
var hasInstanceSymbol = utils.ImportNow("has_instance_symbol");
var isConcatSpreadableSymbol =
@@ -73,18 +72,8 @@ function SymbolKeyFor(symbol) {
return %SymbolRegistry().keyFor[symbol];
}
-
-// ES6 19.1.2.8
-function ObjectGetOwnPropertySymbols(obj) {
- obj = TO_OBJECT(obj);
-
- return %GetOwnPropertyKeys(obj, PROPERTY_FILTER_SKIP_STRINGS);
-}
-
// -------------------------------------------------------------------
-%FunctionSetPrototype(GlobalSymbol, new GlobalObject());
-
utils.InstallConstants(GlobalSymbol, [
// TODO(rossberg): expose when implemented.
// "hasInstance", hasInstanceSymbol,
@@ -108,8 +97,6 @@ utils.InstallFunctions(GlobalSymbol, DONT_ENUM, [
]);
%AddNamedProperty(
- GlobalSymbol.prototype, "constructor", GlobalSymbol, DONT_ENUM);
-%AddNamedProperty(
GlobalSymbol.prototype, toStringTagSymbol, "Symbol", DONT_ENUM | READ_ONLY);
utils.InstallFunctions(GlobalSymbol.prototype, DONT_ENUM | READ_ONLY, [
@@ -121,10 +108,6 @@ utils.InstallFunctions(GlobalSymbol.prototype, DONT_ENUM, [
"valueOf", SymbolValueOf
]);
-utils.InstallFunctions(GlobalObject, DONT_ENUM, [
- "getOwnPropertySymbols", ObjectGetOwnPropertySymbols
-]);
-
// -------------------------------------------------------------------
// Exports
« no previous file with comments | « src/builtins.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698