Chromium Code Reviews Chromium Code Reviews
Issue 158713002:
Move popular DOM attributes to prototype chains (Closed)
Base URL: svn://svn.chromium.org/blink/trunk| Index: LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html |
| diff --git a/LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html b/LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..cb65b16215da719714755e62398f97de03736f62 |
| --- /dev/null |
| +++ b/LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html |
| @@ -0,0 +1,15 @@ |
| +<!DOCTYPE> |
|
arv (Not doing code reviews)
2014/02/10 14:58:15
<!DOCTYPE html>
What you wrote still puts the doc
haraken
2014/02/17 11:26:29
Done.
|
| +<html> |
| +<head> |
| +<script src="../../resources/js-test.js"></script> |
| +</head> |
| +<body> |
| +<script> |
| +var div = document.createElement("div"); |
| +shouldBeFalse('div.hasOwnProperty("id")'); |
| +shouldBeTrue('div.__proto__.__proto__.__proto__.hasOwnProperty("id")'); |
|
arv (Not doing code reviews)
2014/02/10 14:58:15
Next time, please inspect the whole property descr
haraken
2014/02/17 11:26:29
Done.
|
| +shouldThrow('xhr = new XMLHttpRequest(); xhr.__proto__ = HTMLDivElement.prototype; xhr.id'); |
| +shouldThrow('obj = Object.create(div); obj.id'); |
|
arv (Not doing code reviews)
2014/02/10 14:58:15
A better test is to extract the getters and setter
haraken
2014/02/17 11:26:29
Done.
|
| +</script> |
| +</body> |
| +</html> |
