LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html - Issue 158713002: Move popular DOM attributes to prototype chains

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/dom-attribute-on-prototype-chain.html

Issue 158713002: Move popular DOM attributes to prototype chains (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE>
	arv (Not doing code reviews) 2014/02/10 14:58:15 <!DOCTYPE html> What you wrote still puts the doc <!DOCTYPE html> What you wrote still puts the document in quirks mode. haraken 2014/02/17 11:26:29 Done. Show quoted text On 2014/02/10 14:58:15, arv wrote: > <!DOCTYPE html> > > What you wrote still puts the document in quirks mode. Done.
	2 <html>

	3 <head>

	4 <script src="../../resources/js-test.js"></script>

	5 </head>

	6 <body>

	7 <script>

	8 var div = document.createElement("div");

	9 shouldBeFalse('div.hasOwnProperty("id")');

	10 shouldBeTrue('div.__proto__.__proto__.__proto__.hasOwnProperty("id")');
	arv (Not doing code reviews) 2014/02/10 14:58:15 Next time, please inspect the whole property descr Next time, please inspect the whole property descriptor. We should assert the values of get, set, configurable and enumerable. haraken 2014/02/17 11:26:29 Done. Show quoted text On 2014/02/10 14:58:15, arv wrote: > Next time, please inspect the whole property descriptor. We should assert the > values of get, set, configurable and enumerable. Done.
	11 shouldThrow('xhr = new XMLHttpRequest(); xhr.__proto__ = HTMLDivElement.prototyp e; xhr.id');

	12 shouldThrow('obj = Object.create(div); obj.id');
	arv (Not doing code reviews) 2014/02/10 14:58:15 A better test is to extract the getters and setter A better test is to extract the getters and setters and call them var descr = Object.getOwnPropertyDescriptor(Element.prototype, 'id'); shouldThrow('descr.get.call({})'); also test that the setter works. var a = document.createElement('a'); shouldBeUndefined('descr.set.call(a, "abc")'); shouldBeEqualToString('descr.get.call(a)', 'abc'); haraken 2014/02/17 11:26:29 Done. Show quoted text On 2014/02/10 14:58:15, arv wrote: > A better test is to extract the getters and setters and call them > > var descr = Object.getOwnPropertyDescriptor(Element.prototype, 'id'); > shouldThrow('descr.get.call({})'); > > also test that the setter works. > > var a = document.createElement('a'); > shouldBeUndefined('descr.set.call(a, "abc")'); > shouldBeEqualToString('descr.get.call(a)', 'abc'); Done.
	13 </script>

	14 </body>

	15 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/fast/dom/dom-attribute-on-prototype-chain-expected.txt » ('j') | no next file with comments »