Avoid N^2 walk placing renderers when building the render tree

Source/core/css/SiblingTraversalStrategies.h

Index: Source/core/css/SiblingTraversalStrategies.h
diff --git a/Source/core/css/SiblingTraversalStrategies.h b/Source/core/css/SiblingTraversalStrategies.h
index 660a6c5edd3201bb12fbc303dbca15da6c5113de..f325ce018f7b0b43b23fe2f245a624e4284193fa 100644
--- a/Source/core/css/SiblingTraversalStrategies.h
+++ b/Source/core/css/SiblingTraversalStrategies.h
@@ -79,14 +79,8 @@ inline bool DOMSiblingTraversalStrategy::isLastOfType(Element* element, const Qu
 inline int DOMSiblingTraversalStrategy::countElementsBefore(Element* element) const
 {
     int count = 0;
-    for (const Element* sibling = element->previousElementSibling(); sibling; sibling = sibling->previousElementSibling()) {
-        unsigned index = sibling->childIndex();
-        if (index) {
-            count += index;
-            break;
-        }
-        count++;
-    }
+    for (const Element* sibling = element->previousElementSibling(); sibling; sibling = sibling->previousElementSibling())
+        ++count;
 
     return count;
 }
@@ -105,8 +99,14 @@ inline int DOMSiblingTraversalStrategy::countElementsOfTypeBefore(Element* eleme
 inline int DOMSiblingTraversalStrategy::countElementsAfter(Element* element) const
 {
     int count = 0;
-    for (const Element* sibling = element->nextElementSibling(); sibling; sibling = sibling->nextElementSibling())
+    for (const Element* sibling = element->nextElementSibling(); sibling; sibling = sibling->nextElementSibling()) {
+        unsigned index = sibling->childIndex();

[ojan, 2013/06/03 23:03:29]

I think here and in countElementsBefore we need comments explaining why it does
or doesn't make sense to early return (e.g. an early return in
countElementsBefore would actually be *wrong*, not just different performance
and the one here is needed to avoid n^2).

+        if (index) {
+            count += index;
+            break;
+        }
         ++count;
+    }
 
     return count;
 }