Array length reduction should throw in strict mode if it can't delete an element.

Array length reduction should throw in strict mode if it can't delete an element.

When accessor getter callback is called the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according to ES6 there's no difference between strict and non-strict property loads. For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from [arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}

Committed: https://crrev.com/ed2be747ad13746797b655fa4f5c23dc6b0ef3e3
Cr-Commit-Position: refs/heads/master@{#33461}

[Igor Sheludko, 2016-01-14 17:34:34]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-14 17:34:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/1

[commit-bot: I haz the power, 2016-01-14 17:36:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-14 17:36:22]

Dry run: Try jobs failed on following builders:
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_linux_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/59)

[Igor Sheludko, 2016-01-14 18:25:37]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2016-01-14 18:25:38]

PTAL x64, if it looks good I'll make other ports

[Igor Sheludko, 2016-01-15 11:50:17]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2016-01-15 11:51:48]

Addressed comments.

[Toon Verwaest, 2016-01-15 12:48:33]

The language-mode should be part of the array, otherwise it will be a random
value when fetched for a getter. I know *you* don't do this, but if it's part of
the API it needs to make sense in all cases.

[Igor Sheludko, 2016-01-18 18:04:25]

Patchset #3 (id:60001) has been deleted

[Igor Sheludko, 2016-01-19 16:08:35]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called
v8::PropertyCallbackInfo::ShouldThrowOnError() is always set false, since
according to ES6 there's no difference between strict and non-strict property
load. For the setter case v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub.

BUG=v8:4267
LOG=Y
==========

[Igor Sheludko, 2016-01-19 16:09:22]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called
v8::PropertyCallbackInfo::ShouldThrowOnError() is always set false, since
according to ES6 there's no difference between strict and non-strict property
load. For the setter case v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub.

BUG=v8:4267
LOG=Y
==========

[Igor Sheludko, 2016-01-19 18:03:40]

Patchset #4 (id:100001) has been deleted

[Igor Sheludko, 2016-01-19 18:03:57]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 18:04:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/120001

[commit-bot: I haz the power, 2016-01-19 18:07:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 18:07:20]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[Igor Sheludko, 2016-01-19 18:10:56]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicate.

BUG=v8:4267
LOG=Y
==========

[Igor Sheludko, 2016-01-19 18:17:18]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 18:17:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/140001

[commit-bot: I haz the power, 2016-01-19 18:20:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-19 18:20:49]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)

[Igor Sheludko, 2016-01-20 07:59:38]

Patchset #5 (id:140001) has been deleted

[Igor Sheludko, 2016-01-20 08:00:00]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 08:00:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/160001

[Igor Sheludko, 2016-01-20 08:00:54]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicate.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

[Igor Sheludko, 2016-01-20 08:01:46]

Patchset #5 (id:160001) has been deleted

[Igor Sheludko, 2016-01-20 08:03:11]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 08:03:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/180001

[commit-bot: I haz the power, 2016-01-20 08:33:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 08:33:05]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-01-20 09:53:41]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true  in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

[Igor Sheludko, 2016-01-20 09:54:19]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads.
For the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true  in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true  in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

[Igor Sheludko, 2016-01-20 09:54:40]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true  in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

[Igor Sheludko, 2016-01-20 10:06:19]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-20 10:06:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/200001

[Igor Sheludko, 2016-01-20 10:07:30]

Ports are ready, PTAL

[commit-bot: I haz the power, 2016-01-20 10:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 10:30:07]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2016-01-21 11:36:30]

lgtm

[Igor Sheludko, 2016-01-21 11:36:58]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-01-21 11:37:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/200001

[commit-bot: I haz the power, 2016-01-21 11:37:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 11:38:00]

Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/316)
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/1...)
  v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/311)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/build...)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9996)

[Igor Sheludko, 2016-01-21 13:41:50]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-21 13:41:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/220001

[commit-bot: I haz the power, 2016-01-21 14:06:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-21 14:06:32]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-01-21 14:08:25]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-01-21 14:08:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1587073003/#ps220001
(title: "Rebasing")

[commit-bot: I haz the power, 2016-01-21 14:08:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/220001

[commit-bot: I haz the power, 2016-01-21 14:22:56]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

[commit-bot: I haz the power, 2016-01-21 14:22:57]

Committed patchset #7 (id:220001)

[commit-bot: I haz the power, 2016-01-21 14:23:15]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}
==========

[commit-bot: I haz the power, 2016-01-21 14:23:16]

Patchset 7 (id:??) landed as
https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}

[Michael Achenbach, 2016-01-21 18:53:44]

A revert of this CL (patchset #7 id:220001) has been created in
https://codereview.chromium.org/1611313003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks layout tests. Please fix upstream.
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

[Igor Sheludko, 2016-01-22 08:49:27]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}
==========

[Igor Sheludko, 2016-01-22 09:03:14]

On 2016/01/21 18:53:44, Michael Achenbach wrote:
> A revert of this CL (patchset #7 id:220001) has been created in
> https://codereview.chromium.org/1611313003/ by mailto:machenbach@chromium.org.
> 
> The reason for reverting is: [Sheriff] Breaks layout tests. Please fix
upstream.
>
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/bui....

I marked the failing layout test fast/js/mozilla/strict/15.4.5.1.html as
NeedsManualRebaseline, so relanding...

[Igor Sheludko, 2016-01-22 09:03:26]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-01-22 09:03:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/220001

[commit-bot: I haz the power, 2016-01-22 09:05:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 09:05:34]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/10043)

[Igor Sheludko, 2016-01-22 09:20:41]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-01-22 09:20:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
verwaest@chromium.org
Link to the patchset: https://codereview.chromium.org/1587073003/#ps240001
(title: "Rebasing for relanding")

[commit-bot: I haz the power, 2016-01-22 09:20:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1587073003/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1587073003/240001

[commit-bot: I haz the power, 2016-01-22 09:53:33]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}
==========

[commit-bot: I haz the power, 2016-01-22 09:53:34]

Committed patchset #8 (id:240001)

[commit-bot: I haz the power, 2016-01-22 09:53:56]

Description was changed from

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}
==========

to

==========
Array length reduction should throw in strict mode if it can't delete an
element.

When accessor getter callback is called the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, since according
to ES6 there's no difference between strict and non-strict property loads. For
the setter case the v8::PropertyCallbackInfo::ShouldThrowOnError() returns true
if the property is set in strict context.

Interceptors follow same idea: for getter, enumerator and query callbacks the
v8::PropertyCallbackInfo::ShouldThrowOnError() is always false, and for setter
and deleter callback the v8::PropertyCallbackInfo::ShouldThrowOnError() returns
true in strict context.

This CL also cleans up the CallApiGetterStub and removes bogus asserts from
[arm] Push(reg1, reg2, ..., regN) that prevented from pushing a set of registers
containing duplicates.

BUG=v8:4267
LOG=Y

Committed: https://crrev.com/1d3e837fcbbd9d9fd5e72dfe85dfd47c025f3c9f
Cr-Commit-Position: refs/heads/master@{#33438}

Committed: https://crrev.com/ed2be747ad13746797b655fa4f5c23dc6b0ef3e3
Cr-Commit-Position: refs/heads/master@{#33461}
==========

[commit-bot: I haz the power, 2016-01-22 09:53:57]

Patchset 8 (id:??) landed as
https://crrev.com/ed2be747ad13746797b655fa4f5c23dc6b0ef3e3
Cr-Commit-Position: refs/heads/master@{#33461}