Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 1587033002: [Interpreter] Ensure we always have an outer register allocation scope. (Closed)

Created:
4 years, 11 months ago by rmcilroy
Modified:
4 years, 11 months ago
Reviewers:
oth
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_mythri
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Ensure we always have an outer register allocation scope. Split RegisterAllocationScope out of ExpressionResult and allocate one for each statement. This ensures that we always have an outer register allocation scope for statement code (used in CountOperation and RegisterExecutionResult). Also refactored the register allocator code to move it to it's own file and rename from TemporaryRegisterScope to BytecodeRegisterAllocator. BUG=v8:4280 LOG=N Committed: https://crrev.com/ef21fb2de641e804787d146d00c8a02584192781 Cr-Commit-Position: refs/heads/master@{#33296}

Patch Set 1 #

Patch Set 2 : Similarity 20 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+353 lines, -283 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 2 chunks +2 lines, -33 lines 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 1 chunk +0 lines, -57 lines 0 comments Download
M src/interpreter/bytecode-generator.h View 4 chunks +11 lines, -1 line 0 comments Download
M src/interpreter/bytecode-generator.cc View 42 chunks +146 lines, -122 lines 0 comments Download
A + src/interpreter/bytecode-register-allocator.h View 1 1 chunk +26 lines, -28 lines 0 comments Download
A src/interpreter/bytecode-register-allocator.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 5 chunks +0 lines, -6 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 4 chunks +6 lines, -31 lines 0 comments Download
A test/unittests/interpreter/bytecode-register-allocator-unittest.cc View 1 chunk +67 lines, -0 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587033002/1
4 years, 11 months ago (2016-01-14 10:14:46 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 10:39:15 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587033002/20001
4 years, 11 months ago (2016-01-14 11:07:35 UTC) #6
rmcilroy
Orion, please take a look, thanks.
4 years, 11 months ago (2016-01-14 11:07:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-14 12:03:06 UTC) #10
oth
Awesome, lgtm.
4 years, 11 months ago (2016-01-14 13:16:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1587033002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1587033002/20001
4 years, 11 months ago (2016-01-14 13:42:10 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 13:43:19 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 13:43:50 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ef21fb2de641e804787d146d00c8a02584192781
Cr-Commit-Position: refs/heads/master@{#33296}

Powered by Google App Engine
This is Rietveld 408576698