test/cctest/interpreter/test-bytecode-generator.cc - Issue 1587033002: [Interpreter] Ensure we always have an outer register allocation scope.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1587033002: [Interpreter] Ensure we always have an outer register allocation scope. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_mythri

Patch Set: Similarity 20 Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/interpreter/test-bytecode-generator.cc

diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc

index 6094a8f0f3409ac9a759e53dcaba1db15546371e..2c06da26a16b5ca2f0097f48bfb409e292b3f9dc 100644

--- a/test/cctest/interpreter/test-bytecode-generator.cc

+++ b/test/cctest/interpreter/test-bytecode-generator.cc

@@ -5317,7 +5317,7 @@ TEST(ForIn) {

" if (x['a'] == 10) continue;\n"

" if (x['a'] == 20) break;\n"

"}",

- 9 * kPointerSize,

+ 8 * kPointerSize,

94,

{

@@ -5344,17 +5344,17 @@ TEST(ForIn) {

B(Ldar), R(0), //

B(Star), R(6), //

B(LoadICSloppy), R(6), U8(2), U8(vector->GetIndex(slot2)), //

- B(Star), R(8), //

+ B(Star), R(7), //

B(LdaSmi8), U8(10), //

- B(TestEqual), R(8), //

+ B(TestEqual), R(7), //

B(JumpIfFalse), U8(4), //

B(Jump), U8(20), //

B(Ldar), R(0), //

B(Star), R(6), //

B(LoadICSloppy), R(6), U8(2), U8(vector->GetIndex(slot3)), //

- B(Star), R(8), //

+ B(Star), R(7), //

B(LdaSmi8), U8(20), //

- B(TestEqual), R(8), //

+ B(TestEqual), R(7), //

B(JumpIfFalse), U8(4), //

B(Jump), U8(8), //

B(ForInStep), R(5), //

« no previous file with comments | « src/interpreter/bytecode-register-allocator.cc ('k') | test/cctest/interpreter/test-interpreter.cc » ('j') | no next file with comments »