Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 1586903002: [DevTools] Whitelist remoteBase and loadNetworkResource schemes. (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
taviso1, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Whitelist remoteBase and loadNetworkResource schemes. BUG=571121 Committed: https://crrev.com/e8ecfb59d4f906e0ab40b6046406b8af1366cb10 Cr-Commit-Position: refs/heads/master@{#369327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/devtools/devtools_ui_bindings.cc View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Runtime.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
dgozman
Take a look please.
3 years, 7 months ago (2016-01-14 00:33:44 UTC) #2
pfeldman
lgtm
3 years, 7 months ago (2016-01-14 00:35:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586903002/1
3 years, 7 months ago (2016-01-14 00:42:57 UTC) #5
taviso1
On 2016/01/14 00:42:57, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
3 years, 7 months ago (2016-01-14 01:57:33 UTC) #6
taviso1
On 2016/01/14 00:33:44, dgozman wrote: > Take a look please. lgtm, looks like this covers ...
3 years, 7 months ago (2016-01-14 01:58:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
3 years, 7 months ago (2016-01-14 02:49:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586903002/1
3 years, 7 months ago (2016-01-14 03:38:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 7 months ago (2016-01-14 04:40:04 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2016-01-14 04:41:31 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8ecfb59d4f906e0ab40b6046406b8af1366cb10
Cr-Commit-Position: refs/heads/master@{#369327}

Powered by Google App Engine
This is Rietveld 408576698