ppapi/shared_impl/ppb_graphics_3d_shared.h - Issue 1586883002: Converted Ppapi post swap buffer sync point to use sync tokens.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/ppb_graphics_3d_shared.h

Issue 1586883002: Converted Ppapi post swap buffer sync point to use sync tokens. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed some .get() booleans Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/shared_impl/ppb_graphics_3d_shared.h

diff --git a/ppapi/shared_impl/ppb_graphics_3d_shared.h b/ppapi/shared_impl/ppb_graphics_3d_shared.h

index 87ee9d6cb2a7c0355d2b914dcb6d7c30a0a136c9..3ee595eb0e248e4f0dbd4c7fc1efff93a9c76513 100644

--- a/ppapi/shared_impl/ppb_graphics_3d_shared.h

+++ b/ppapi/shared_impl/ppb_graphics_3d_shared.h

@@ -40,7 +40,8 @@ class PPAPI_SHARED_EXPORT PPB_Graphics3D_Shared

int32_t SetAttribs(const int32_t attrib_list[]) override;

int32_t GetError() override;

int32_t ResizeBuffers(int32_t width, int32_t height) override;

- int32_t SwapBuffers(scoped_refptr<TrackedCallback> callback) override;

+ int32_t SwapBuffers(scoped_refptr<TrackedCallback> callback,

+ const gpu::SyncToken& sync_token) override;

int32_t GetAttribMaxValue(int32_t attribute, int32_t* value) override;

void* MapTexSubImage2DCHROMIUM(GLenum target,

@@ -67,7 +68,7 @@ class PPAPI_SHARED_EXPORT PPB_Graphics3D_Shared

virtual gpu::CommandBuffer* GetCommandBuffer() = 0;

virtual gpu::GpuControl* GetGpuControl() = 0;

- virtual int32_t DoSwapBuffers() = 0;

+ virtual int32_t DoSwapBuffers(const gpu::SyncToken& sync_token) = 0;

bool HasPendingSwap() const;

bool CreateGLES2Impl(int32_t command_buffer_size,

« no previous file with comments | « ppapi/proxy/ppb_graphics_3d_proxy.cc ('k') | ppapi/shared_impl/ppb_graphics_3d_shared.cc » ('j') | no next file with comments »