Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1586773002: Reland "[DevTools] More Device Mode polish." (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "[DevTools] More Device Mode polish." [DevTools] More Device Mode polish. - fixed ruler in overlay with page scale factor; - dimming zoom label based on some content being cropped; - added dpr and ua type labels; - fixed fit calculations; - string updates. BUG=540864 Original patch: https://codereview.chromium.org/1575203003 TBR=pfeldman Committed: https://crrev.com/597361f6e127d878cf632e95c0ce648868684b9c Cr-Commit-Position: refs/heads/master@{#369309}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -22 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 8 chunks +19 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 9 chunks +48 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586773002/1
4 years, 11 months ago (2016-01-13 20:43:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586773002/1
4 years, 11 months ago (2016-01-13 23:35:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
4 years, 11 months ago (2016-01-13 23:51:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586773002/1
4 years, 11 months ago (2016-01-14 00:08:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_compile_dbg on ...
4 years, 11 months ago (2016-01-14 00:12:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586773002/1
4 years, 11 months ago (2016-01-14 00:29:43 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-14 01:41:00 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586773002/1
4 years, 11 months ago (2016-01-14 02:18:30 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:38:40 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:39:44 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/597361f6e127d878cf632e95c0ce648868684b9c
Cr-Commit-Position: refs/heads/master@{#369309}

Powered by Google App Engine
This is Rietveld 408576698