Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 1575203003: [DevTools] More Device Mode polish. (Closed)

Created:
4 years, 11 months ago by dgozman
Modified:
4 years, 11 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] More Device Mode polish. - fixed ruler in overlay with page scale factor; - dimming zoom label based on some content being cropped; - added dpr and ua type labels; - fixed fit calculations; - string updates. BUG=540864 Committed: https://crrev.com/a15860e14bdca7cba13cad960008e0581836b93b Cr-Commit-Position: refs/heads/master@{#368822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -18 lines) Patch
M third_party/WebKit/Source/core/inspector/InspectorOverlayPage.html View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 8 chunks +19 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 9 chunks +46 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/deviceModeView.css View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 2 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
4 years, 11 months ago (2016-01-12 02:20:10 UTC) #2
pfeldman
lgtm
4 years, 11 months ago (2016-01-12 02:24:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575203003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575203003/1
4 years, 11 months ago (2016-01-12 05:47:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 08:40:31 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a15860e14bdca7cba13cad960008e0581836b93b Cr-Commit-Position: refs/heads/master@{#368822}
4 years, 11 months ago (2016-01-12 08:42:46 UTC) #8
pfeldman
4 years, 11 months ago (2016-01-12 19:34:27 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1574373002/ by pfeldman@chromium.org.

The reason for reverting is: Breaks responsive mode..

Powered by Google App Engine
This is Rietveld 408576698