VM: Don't do free("") in shutdown when we can't find the cpu model field in /proc/cpuinfo.

VM: Don't do free("") in shutdown when we can't find the cpu model field in /proc/cpuinfo.

Also fix field names of /proc/cpuinfo for Linux ARM64.

BUG=http://dartbug.com/25424
R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/2ebe6f459ee8fcb6c2f9a814fc348df4719166f3

[rmacnak, 2016-01-13 22:33:55]

Description was changed from

==========
VM: Don't do free("") in shutdown when we can't find a /proc/cpuinfo field.

Also fix field names of /proc/cpuinfo for Linux ARM64.

BUG=http://dartbug.com/25424
==========

to

==========
VM: Don't do free("") in shutdown when we can't find the cpu model field in
/proc/cpuinfo.

Also fix field names of /proc/cpuinfo for Linux ARM64.

BUG=http://dartbug.com/25424
==========

[rmacnak, 2016-01-13 22:35:24]

rmacnak@google.com changed reviewers:
+ zra@google.com

[rmacnak, 2016-01-13 22:35:25]

Including for reference what /proc/cpuinfo looks like on {Linux,Android} x
{armhf,arm64}.


***Raspberry Pi 2 (Linux arm32)
cat /proc/cpuinfo
...
processor	: 3
model name	: ARMv7 Processor rev 5 (v7l)
BogoMIPS	: 38.40
Features	: half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 idiva idivt vfpd32
lpae evtstrm 
CPU implementer	: 0x41
CPU architecture: 7
CPU variant	: 0x0
CPU part	: 0xc07
CPU revision	: 5

Hardware	: BCM2709
Revision	: 0000
Serial		: 0000000000000000


***DragonBoard 410c (Linux arm64)
cat /proc/cpuinfo
...
processor	: 3
Features	: fp asimd evtstrm crc32
CPU implementer	: 0x41
CPU architecture: 8
CPU variant	: 0x0
CPU part	: 0xd03
CPU revision	: 0


***Nexus 4 (Android arm32)
cat /proc/cpuinfo
Processor	: ARMv7 Processor rev 2 (v7l)
processor	: 0
BogoMIPS	: 13.53

processor	: 1
BogoMIPS	: 13.53

processor	: 2
BogoMIPS	: 13.53

processor	: 3
BogoMIPS	: 13.53

Features	: swp half thumb fastmult vfp edsp neon vfpv3 tls vfpv4 
CPU implementer	: 0x51
CPU architecture: 7
CPU variant	: 0x0
CPU part	: 0x06f
CPU revision	: 2

Hardware	: QCT APQ8064 MAKO
Revision	: 000b
Serial		: 0000000000000000


***Nexus 9 (Android arm64)
cat /proc/cpuinfo
Processor	: NVIDIA Denver 1.0 rev 0 (aarch64)
processor	: 0
processor	: 1
Features	: fp asimd aes pmull sha1 sha2 crc32 
CPU implementer	: 0x4e
CPU architecture: AArch64
CPU variant	: 0x0
CPU part	: 0x000
CPU revision	: 0

Hardware	: Flounder
Revision	: 0000
Serial		: 0000000000000000
MTS version	: 33903942

[zra, 2016-01-13 22:40:24]

https://codereview.chromium.org/1586663005/diff/1/runtime/vm/cpuinfo_linux.cc
File runtime/vm/cpuinfo_linux.cc (right):

https://codereview.chromium.org/1586663005/diff/1/runtime/vm/cpuinfo_linux.cc...
runtime/vm/cpuinfo_linux.cc:39: fields_[kCpuInfoProcessor] = "processor";
Should this be Processor?

lower-case processor looks like it is usually just a processor id, which is
probably not what we want for this field.

[rmacnak, 2016-01-13 23:15:56]

https://codereview.chromium.org/1586663005/diff/1/runtime/vm/cpuinfo_linux.cc
File runtime/vm/cpuinfo_linux.cc (right):

https://codereview.chromium.org/1586663005/diff/1/runtime/vm/cpuinfo_linux.cc...
runtime/vm/cpuinfo_linux.cc:39: fields_[kCpuInfoProcessor] = "processor";
On 2016/01/13 22:40:24, zra wrote:
> Should this be Processor?
> 
> lower-case processor looks like it is usually just a processor id, which is
> probably not what we want for this field.

Hm, 'processor' does look like a processor id. But 'Processor' is missing for
both ARMs. Maybe use

fields_[kCpuInfoProcessor] = "undefined";

for both the ARMs?

[rmacnak, 2016-01-13 23:52:29]

With "Processor" and a value of "Unknown" if we can't find it in cpuinfo

[zra, 2016-01-13 23:58:31]

lgtm

[rmacnak, 2016-01-14 00:37:32]

Description was changed from

==========
VM: Don't do free("") in shutdown when we can't find the cpu model field in
/proc/cpuinfo.

Also fix field names of /proc/cpuinfo for Linux ARM64.

BUG=http://dartbug.com/25424
==========

to

==========
VM: Don't do free("") in shutdown when we can't find the cpu model field in
/proc/cpuinfo.

Also fix field names of /proc/cpuinfo for Linux ARM64.

BUG=http://dartbug.com/25424
R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2ebe6f459ee8fcb6c2f9a814fc348df4719166f3
==========

[rmacnak, 2016-01-14 00:37:33]

Committed patchset #3 (id:40001) manually as
2ebe6f459ee8fcb6c2f9a814fc348df4719166f3 (presubmit successful).