runtime/vm/cpuinfo.h - Issue 1586663005: VM: Don't do free("") in shutdown when we can't find the cpu model field in /proc/cpuinfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cpuinfo.h

Issue 1586663005: VM: Don't do free("") in shutdown when we can't find the cpu model field in /proc/cpuinfo. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/cpuinfo.h

diff --git a/runtime/vm/cpuinfo.h b/runtime/vm/cpuinfo.h

index 3ccf2d4fb16d0cb1bda24b64a46ee8338df8c327..cd1247ea22b8600b9cfb205502863a205c5d7f16 100644

--- a/runtime/vm/cpuinfo.h

+++ b/runtime/vm/cpuinfo.h

@@ -61,7 +61,7 @@ class CpuInfo : public AllStatic {

if (HasField(FieldName(kCpuInfoHardware))) {

return ExtractField(kCpuInfoHardware);

} else {

- return "";

+ return strdup("Unknown");

}

« no previous file with comments | « no previous file | runtime/vm/cpuinfo_linux.cc » ('j') | no next file with comments »