Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1586663004: Componentize IDS_PRINT string so that it can be shared on iOS. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
droger, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@ids-close
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize IDS_PRINT string so that it can be shared on iOS. BUG=568486 TBR=sky@chromium.org Committed: https://crrev.com/7d6f3c1e44ef89b5c005bfb167305b63e1b5fcc5 Cr-Commit-Position: refs/heads/master@{#369369}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/toolbar/app_menu_model.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_strings.grd View 1 chunk +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 1582893002 Patch 1

Messages

Total messages: 12 (5 generated)
sdefresne
Please take a look.
4 years, 11 months ago (2016-01-13 17:10:59 UTC) #2
droger
lgtm
4 years, 11 months ago (2016-01-13 17:11:59 UTC) #3
sdefresne
TBR sky: please review the following as OWNERS - chrome/browser/ui/toolbar/app_menu_model.cc - chrome/browser/ui/views/frame/global_menu_bar_x11.cc
4 years, 11 months ago (2016-01-14 07:56:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1586663004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1586663004/1
4 years, 11 months ago (2016-01-14 07:57:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 08:40:27 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7d6f3c1e44ef89b5c005bfb167305b63e1b5fcc5 Cr-Commit-Position: refs/heads/master@{#369369}
4 years, 11 months ago (2016-01-14 08:42:04 UTC) #11
sky
4 years, 11 months ago (2016-01-14 16:00:48 UTC) #12
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698