Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1582893002: Componentize IDS_CLOSE string so that it can be shared with iOS. (Closed)

Created:
4 years, 11 months ago by sdefresne
Modified:
4 years, 11 months ago
Reviewers:
droger, sky
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, davemoore+watch_chromium.org, extensions-reviews_chromium.org, oshima+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize IDS_CLOSE string so that it can be shared with iOS. BUG=568486 Committed: https://crrev.com/384a2404d4c7d4f0ba1e62866785c70cdb2f87c2 Cr-Commit-Position: refs/heads/master@{#369359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/first_run_private_api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/collected_cookies_views.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/system_menu_model_builder.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/certificate_viewer_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1586663004 Patch 1

Messages

Total messages: 11 (4 generated)
sdefresne
Please take a look.
4 years, 11 months ago (2016-01-13 16:55:25 UTC) #2
droger
lgtm
4 years, 11 months ago (2016-01-13 16:58:03 UTC) #3
sdefresne
sky: please review the following as OWNERS chrome/browser/chromeos/extensions/first_run_private_api.cc chrome/browser/ui/views/collected_cookies_views.cc chrome/browser/ui/views/frame/system_menu_model_builder.cc chrome/browser/ui/webui/certificate_viewer_ui.cc
4 years, 11 months ago (2016-01-13 17:36:51 UTC) #5
sky
LGTM - feel free to TBR this sort of change.
4 years, 11 months ago (2016-01-13 18:45:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582893002/1
4 years, 11 months ago (2016-01-14 07:14:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 07:18:33 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 07:20:03 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/384a2404d4c7d4f0ba1e62866785c70cdb2f87c2
Cr-Commit-Position: refs/heads/master@{#369359}

Powered by Google App Engine
This is Rietveld 408576698