Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1586653003: - Allow specifying of package: URIs for packageConfig and packageRoot when (Closed)

Created:
4 years, 11 months ago by Ivan Posva
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Allow specifying of package: URIs for packageConfig and packageRoot when spawning a new isolate. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/7b75f2dbb7642732f15ec3f810f91f8a6db3e4f6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -31 lines) Patch
M runtime/lib/isolate_patch.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/scenarios/automatic_resolution_root/package_resolve_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/scenarios/automatic_resolution_spec/package_resolve_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/isolate/scenarios/package_relative_root/package_relative_root_test.dart View 1 chunk +22 lines, -14 lines 0 comments Download
A tests/isolate/scenarios/package_relative_root/packages/bar/bar.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_root/packages/bar/spawned_packages/bar/bar.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_root/packages/bar/spawned_packages/foo/foo.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_root/packages/foo/foo.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_spec/.packages View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_spec/bar1_package/bar.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_spec/bar1_package/package.config View 1 chunk +4 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_spec/bar2_package/bar.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A tests/isolate/scenarios/package_relative_spec/foo_package/foo.dart View 1 chunk +3 lines, -0 lines 0 comments Download
A + tests/isolate/scenarios/package_relative_spec/package_relative_spec_test.dart View 1 chunk +22 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Ivan Posva
4 years, 11 months ago (2016-01-13 23:53:21 UTC) #2
rmacnak
lgtm
4 years, 11 months ago (2016-01-14 00:48:24 UTC) #3
Ivan Posva
4 years, 11 months ago (2016-01-14 16:21:07 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7b75f2dbb7642732f15ec3f810f91f8a6db3e4f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698