Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2592)

Unified Diff: runtime/lib/isolate_patch.dart

Issue 1586653003: - Allow specifying of package: URIs for packageConfig and packageRoot when (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tests/isolate/isolate.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/isolate_patch.dart
diff --git a/runtime/lib/isolate_patch.dart b/runtime/lib/isolate_patch.dart
index de652acac29bd1541f7e6cc96f3b52a9db2ada37..79c895a87a3206d1be92c84eb517672bc87e4568 100644
--- a/runtime/lib/isolate_patch.dart
+++ b/runtime/lib/isolate_patch.dart
@@ -378,6 +378,12 @@ patch class Isolate {
}
}
+ // Ensure to resolve package: URIs being handed in as parameters.
+ packageRoot = (packageRoot == null) ? null :
+ await Isolate.resolvePackageUri(packageRoot);
+ packageConfig = (packageConfig == null) ? null :
+ await Isolate.resolvePackageUri(packageConfig);
+
// The VM will invoke [_startIsolate] and not `main`.
readyPort = new RawReceivePort();
var packageRootString = packageRoot?.toString();
« no previous file with comments | « no previous file | tests/isolate/isolate.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698