components/sync_driver/sync_prefs.cc - Issue 1586563004: [Sync] Don't set sync requested when setting setup completed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/sync_prefs.cc

Issue 1586563004: [Sync] Don't set sync requested when setting setup completed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/sync_driver/sync_prefs.cc

diff --git a/components/sync_driver/sync_prefs.cc b/components/sync_driver/sync_prefs.cc

index 6f005ec8bb9058fc435945041d11e7d30867a042..2f3619abac64f309824d414044ec07be7a523d66 100644

--- a/components/sync_driver/sync_prefs.cc

+++ b/components/sync_driver/sync_prefs.cc

@@ -129,7 +129,6 @@ bool SyncPrefs::HasSyncSetupCompleted() const {

void SyncPrefs::SetSyncSetupCompleted() {

DCHECK(CalledOnValidThread());

pref_service_->SetBoolean(prefs::kSyncHasSetupCompleted, true);

- SetSyncRequested(true);

Nicolas Zea 2016/01/15 21:21:19 Does it make sense to DCHECK that sync was already

maxbogue 2016/01/20 18:31:55 Not really any reason to. I think it will be easie

}

bool SyncPrefs::SyncHasAuthError() const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »