[Sync] Don't set sync requested when setting setup completed.

components/sync_driver/sync_prefs.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync_driver/sync_prefs.h"
 
 #include "base/base64.h"
 #include "base/logging.h"
 #include "base/prefs/pref_member.h"
 #include "base/prefs/pref_service.h"
@@ skipping 111 matching lines @@
 }
 
 bool SyncPrefs::HasSyncSetupCompleted() const {
   DCHECK(CalledOnValidThread());
   return pref_service_->GetBoolean(prefs::kSyncHasSetupCompleted);
 }
 
 void SyncPrefs::SetSyncSetupCompleted() {
   DCHECK(CalledOnValidThread());
   pref_service_->SetBoolean(prefs::kSyncHasSetupCompleted, true);
-  SetSyncRequested(true);

[Nicolas Zea, 2016/01/15 21:21:19]

Does it make sense to DCHECK that sync was already requested? It seems like that
should be the case right?

[maxbogue, 2016/01/20 18:31:55]

Not really any reason to. I think it will be easier to not have to worry about
that in some startup circumstances, and it wouldn't really help anything.

 }
 
 bool SyncPrefs::SyncHasAuthError() const {
   DCHECK(CalledOnValidThread());
   return pref_service_->GetBoolean(prefs::kSyncHasAuthError);
 }
 
 void SyncPrefs::SetSyncAuthError(bool error) {
   DCHECK(CalledOnValidThread());
   pref_service_->SetBoolean(prefs::kSyncHasAuthError, error);
@@ skipping 412 matching lines @@
     return scoped_ptr<syncer::SyncEncryptionHandler::NigoriState>();
 
   scoped_ptr<syncer::SyncEncryptionHandler::NigoriState> result(
       new syncer::SyncEncryptionHandler::NigoriState());
   if (!result->nigori_specifics.ParseFromString(decoded))
     return scoped_ptr<syncer::SyncEncryptionHandler::NigoriState>();
   return result;
 }
 
 }  // namespace sync_driver