Adding an API to read module annotations in snapshot.gyp

snapshot/snapshot.gyp

Index: snapshot/snapshot.gyp
diff --git a/snapshot/snapshot.gyp b/snapshot/snapshot.gyp
index 3f7c63ee264a160f0b9ba3442f1c77484b5326ff..a15dfe60397f1daaf10ba9218237507ffae7961f 100644
--- a/snapshot/snapshot.gyp
+++ b/snapshot/snapshot.gyp
@@ -127,5 +127,21 @@
         }],
       ]
     },
+    {
+      'target_name': 'snapshot_client',

[scottmg, 2016/01/13 19:12:42]

This should probably be 'crashpad_' prefixed for consistency.

[scottmg, 2016/01/13 19:12:42]

I think 'client' is a bit confusing because it won't necessarily be in a client
(in the sense that it's registering with the handler).

Maybe 'api'? Or maybe Mark has a better suggestion.

[Patrick Monette, 2016/01/13 22:59:40]

Done.

[Patrick Monette, 2016/01/13 22:59:40]

Done.

+      'type': 'static_library',
+      'dependencies': [
+        'crashpad_snapshot',
+        '../compat/compat.gyp:crashpad_compat',
+        '../third_party/mini_chromium/mini_chromium.gyp:base',
+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'sources': [
+        'client/crashpad_annotations_win.cc',

[scottmg, 2016/01/13 19:12:42]

api/ here too.

[scottmg, 2016/01/13 19:12:42]

(This will be an empty target on non-Windows, not sure if that will cause
problems.)

[Patrick Monette, 2016/01/13 22:59:40]

Done.

[Patrick Monette, 2016/01/13 22:59:40]

Fixed.

+        'client/crashpad_annotations_win.h',
+      ],
+    },
   ],
 }