Adding an API to read module annotations in snapshot.gyp

snapshot/snapshot.gyp

 # Copyright 2014 The Crashpad Authors. All rights reserved.
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
 #
 #     http://www.apache.org/licenses/LICENSE-2.0
 #
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 109 matching lines @@
         ['OS=="win"', {
           'link_settings': {
             'libraries': [
               '-lpowrprof.lib',
               '-lversion.lib',
             ],
           },
         }],
       ]
     },
+    {
+      'target_name': 'snapshot_client',

[scottmg, 2016/01/13 19:12:42]

This should probably be 'crashpad_' prefixed for consistency.

[scottmg, 2016/01/13 19:12:42]

I think 'client' is a bit confusing because it won't necessarily be in a client
(in the sense that it's registering with the handler).

Maybe 'api'? Or maybe Mark has a better suggestion.

[Patrick Monette, 2016/01/13 22:59:40]

Done.

[Patrick Monette, 2016/01/13 22:59:40]

Done.

+      'type': 'static_library',
+      'dependencies': [
+        'crashpad_snapshot',
+        '../compat/compat.gyp:crashpad_compat',
+        '../third_party/mini_chromium/mini_chromium.gyp:base',
+      ],
+      'include_dirs': [
+        '..',
+      ],
+      'sources': [
+        'client/crashpad_annotations_win.cc',

[scottmg, 2016/01/13 19:12:42]

api/ here too.

[scottmg, 2016/01/13 19:12:42]

(This will be an empty target on non-Windows, not sure if that will cause
problems.)

[Patrick Monette, 2016/01/13 22:59:40]

Done.

[Patrick Monette, 2016/01/13 22:59:40]

Fixed.

+        'client/crashpad_annotations_win.h',
+      ],
+    },
   ],
 }