chrome/browser/resources/md_history/history_toolbar.js - Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history_toolbar.js

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded

Patch Set: Address reviewer comments: add tests for deletion and logic for supervised users. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/md_history/history_item.js ('K') | « chrome/browser/resources/md_history/history_toolbar.html ('k') | chrome/browser/ui/webui/md_history_ui.cc » ('j') | chrome/browser/ui/webui/md_history_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history_toolbar.js

diff --git a/chrome/browser/resources/md_history/history_toolbar.js b/chrome/browser/resources/md_history/history_toolbar.js

index 7339c516daf92daab305ef90c8ad6a948541c0af..d39094249587c647d4220543633048670beb2ed6 100644

--- a/chrome/browser/resources/md_history/history_toolbar.js

+++ b/chrome/browser/resources/md_history/history_toolbar.js

@@ -31,5 +31,17 @@ Polymer({

clearSelection: function() {

this.fire('unselect-all');

+ },

+ deleteSelection: function() {

+ this.fire('delete-selected');

+ },

+ /**

+ * If the user is a supervised user the delete button is not shown.

+ * @private

+ */

+ deletingAllowed_: function() {

+ return loadTimeData.getBoolean('allowDeletingHistory');

}

});