Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: chrome/browser/resources/md_history/history_item.js

Issue 1586373002: MD History: Delete button in the toolbar allows deletion of multiple history-items. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@patch_to_be_uploaded
Patch Set: Address reviewer comments: add tests for deletion and logic for supervised users. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_history/history_item.js
diff --git a/chrome/browser/resources/md_history/history_item.js b/chrome/browser/resources/md_history/history_item.js
index 2497db1bdbde186501d92266724742850b638673..519ce625ffaa190f4731c2a15ad1785e50878381 100644
--- a/chrome/browser/resources/md_history/history_item.js
+++ b/chrome/browser/resources/md_history/history_item.js
@@ -89,5 +89,9 @@ Polymer({
});
// Stops the 'tap' event from closing the menu when it opens.
e.stopPropagation();
+ },
+
+ selectionAllowed_: function() {
+ return !loadTimeData.getBoolean('allowDeletingHistory');
calamity 2016/01/21 00:11:09 It's sad that this needs to be retrieved twice. Ti
hsampson 2016/01/21 05:34:47 Acknowledged.
}
});

Powered by Google App Engine
This is Rietveld 408576698